From 4287b4e84c4af7a331d1b0a390ab3d97f37120c2 Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Tue, 25 Jul 2017 12:20:23 +0200 Subject: [PATCH] Fix wrong condition in ipa-visibility.c (PR ipa/81520). 2017-07-25 Martin Liska PR ipa/81520 * ipa-visibility.c (function_and_variable_visibility): Make the redirection just on target that do supporting aliasing. Fix GNU coding style. 2017-07-25 Martin Liska PR ipa/81520 * gcc.dg/ipa/pr81520.c: New test. From-SVN: r250501 --- gcc/ChangeLog | 6 ++++++ gcc/ipa-visibility.c | 11 +++++++---- gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/gcc.dg/ipa/pr81520.c | 11 +++++++++++ 4 files changed, 29 insertions(+), 4 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/ipa/pr81520.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index fa58d51012b..9177c6a8f5b 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2017-07-25 Martin Liska + + PR ipa/81520 + * ipa-visibility.c (function_and_variable_visibility): Make the redirection + just on target that do supporting aliasing. Fix GNU coding style. + 2017-07-25 Sebastian Huber PR libgcc/61152 diff --git a/gcc/ipa-visibility.c b/gcc/ipa-visibility.c index 21321703dbb..13cf2a3a1cf 100644 --- a/gcc/ipa-visibility.c +++ b/gcc/ipa-visibility.c @@ -615,9 +615,10 @@ function_and_variable_visibility (bool whole_program) struct cgraph_node *node; varpool_node *vnode; - /* All aliases should be procssed at this point. */ + /* All aliases should be processed at this point. */ gcc_checking_assert (!alias_pairs || !alias_pairs->length ()); +#ifdef ASM_OUTPUT_DEF FOR_EACH_DEFINED_FUNCTION (node) { if (node->get_availability () != AVAIL_INTERPOSABLE @@ -634,20 +635,22 @@ function_and_variable_visibility (bool whole_program) continue; if (!alias) - { + { alias = dyn_cast (node->noninterposable_alias ()); gcc_assert (alias && alias != node); } e->redirect_callee (alias); if (gimple_has_body_p (e->caller->decl)) - { + { push_cfun (DECL_STRUCT_FUNCTION (e->caller->decl)); e->redirect_call_stmt_to_callee (); - pop_cfun (); + pop_cfun (); } } } +#endif + FOR_EACH_FUNCTION (node) { int flags = flags_from_decl_or_type (node->decl); diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index f3a4812308c..2762ae5b70f 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2017-07-25 Martin Liska + + PR ipa/81520 + * gcc.dg/ipa/pr81520.c: New test. + 2017-07-25 Marek Polacek PR c/81364 diff --git a/gcc/testsuite/gcc.dg/ipa/pr81520.c b/gcc/testsuite/gcc.dg/ipa/pr81520.c new file mode 100644 index 00000000000..b5d33d2dc96 --- /dev/null +++ b/gcc/testsuite/gcc.dg/ipa/pr81520.c @@ -0,0 +1,11 @@ +/* PR ipa/81520 */ +/* { dg-do compile } */ +/* { dg-options "-O2 -fPIC" } */ +/* { dg-require-effective-target fpic } */ + +char +a (int b) +{ + a (b); + return 0; +} -- 2.30.2