From 429c15693cbc151d24546c397e8c7435f77e1b14 Mon Sep 17 00:00:00 2001 From: Ian Lance Taylor Date: Wed, 29 Aug 2007 05:48:24 +0000 Subject: [PATCH] Any symbol which is in both a regular object and a dynamic object requires an entry in the dynamic symbol table. --- gold/resolve.cc | 9 --------- gold/symtab.h | 5 ++++- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/gold/resolve.cc b/gold/resolve.cc index f80e08f92e4..d02159824af 100644 --- a/gold/resolve.cc +++ b/gold/resolve.cc @@ -189,15 +189,6 @@ Symbol_table::resolve(Sized_symbol* to, break; } - if ((tobits & (1 << 1)) != (frombits & (1 << 1))) - { - // This symbol is seen in both a dynamic object and a regular - // object. That means that we need the symbol to go into the - // dynamic symbol table, so that the dynamic linker can use the - // regular symbol to override or define the dynamic symbol. - to->set_needs_dynsym_entry(); - } - // FIXME: Warn if either but not both of TO and SYM are STT_TLS. // We use a giant switch table for symbol resolution. This code is diff --git a/gold/symtab.h b/gold/symtab.h index 15d1f788eb0..816afb3884a 100644 --- a/gold/symtab.h +++ b/gold/symtab.h @@ -178,7 +178,10 @@ class Symbol // table. bool needs_dynsym_entry() const - { return this->needs_dynsym_entry_; } + { + return (this->needs_dynsym_entry_ + || (this->in_reg() && this->in_dyn())); + } // Mark this symbol as needing an entry in the dynamic symbol table. void -- 2.30.2