From 42d9e5288b6576b56f3f803901433b88ee863bc6 Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Wed, 4 Feb 2015 14:53:24 +0100 Subject: [PATCH] Fix '--target_board=native-extended-gdbserver/-m32' Running the testsuite with the native-extended-gdbserver.exp board and passing a variant spec, like make check RUNTESTFLAGS="--target_board=native-extended-gdbserver/-m32" results in dejagnu trying to open a rsh connection to "native-extended-gdbserver", which of course is wrong. The point of this board is running things locally. The issue is that the native-extended-gdbserver board does not clear the "isremote" flag properly. Reported by Sergio at: https://sourceware.org/ml/gdb-patches/2015-02/msg00067.html testsuite/ 2015-02-04 Pedro Alves * boards/native-extended-gdbserver.exp: Remove any target variant specifications from the board name before clearing the isremote flag from board_info. --- gdb/testsuite/ChangeLog | 6 ++++++ gdb/testsuite/boards/native-extended-gdbserver.exp | 4 +++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 26579871164..fcc16cb15b8 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2015-02-04 Pedro Alves + + * boards/native-extended-gdbserver.exp: Remove any target variant + specifications from the board name before clearing the isremote + flag from board_info. + 2015-01-31 Doug Evans * gdb.base/maint.exp : Update expected output. diff --git a/gdb/testsuite/boards/native-extended-gdbserver.exp b/gdb/testsuite/boards/native-extended-gdbserver.exp index 57503db86bd..8d299ef3f63 100644 --- a/gdb/testsuite/boards/native-extended-gdbserver.exp +++ b/gdb/testsuite/boards/native-extended-gdbserver.exp @@ -27,7 +27,9 @@ load_board_description "gdbserver-base" # matches localhost. Force it to be NOT remote. global board global board_info -set board_info($board,isremote) 0 +# Remove any target variant specifications from the name. +set baseboard [lindex [split $board "/"] 0] +set board_info($baseboard,isremote) 0 set_board_info sockethost "localhost:" -- 2.30.2