From 431a6d708b4346ec81bade79033cc34308a5144f Mon Sep 17 00:00:00 2001 From: Andreas Sandberg Date: Wed, 11 Feb 2015 10:23:22 -0500 Subject: [PATCH] dev: Remove unused system pointer in the Platform base class The Platform base class contains a pointer to an instance of the System which is never initialized. This can lead to subtle bugs since some architecture-specific platform implementations contain their own system pointer which is normally used. However, if the platform is accessed through a pointer to its base class, the dangling pointer will be used instead. --- src/dev/platform.hh | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/dev/platform.hh b/src/dev/platform.hh index b3d1bec9f..0931d9ece 100644 --- a/src/dev/platform.hh +++ b/src/dev/platform.hh @@ -55,9 +55,6 @@ class Platform : public SimObject /** Pointer to the interrupt controller */ IntrControl *intrctrl; - /** Pointer to the system for info about the memory system. */ - System *system; - public: typedef PlatformParams Params; Platform(const Params *p); -- 2.30.2