From 444e826c911693e6dad1cf907d81eb9dc1bef7d2 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Mon, 2 May 2016 13:10:33 -0400 Subject: [PATCH] Fix detach.exp remote check This test seems to work with both native-gdbserver and native-extended-gdbserver, so I removed the remote check. When running with native-gdbserver (a stub-like target), detach makes gdbserver stop and gdb disconnect. runto_main just spawns a brand new gdbserver. So it tests the exact same thing twice. It doesn't hurt though. With native-extended-gdbserver, the test is probably a bit more useful (and similar to native). It tests running/detaching twice using the same gdb/gdbserver instances, since with extended-remote, you can detach/attach/run all you want, unlike with remote. gdb/testsuite/ChangeLog: * gdb.base/detach.exp: Remove is_remote check. --- gdb/testsuite/ChangeLog | 4 ++++ gdb/testsuite/gdb.base/detach.exp | 5 ----- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index fb6538ca6ea..6d34da6d368 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2016-05-02 Simon Marchi + + * gdb.base/detach.exp: Remove is_remote check. + 2016-05-02 Simon Marchi * gdb.base/annota-input-while-running.exp: Don't check for diff --git a/gdb/testsuite/gdb.base/detach.exp b/gdb/testsuite/gdb.base/detach.exp index 920dac21c31..b9343ee255a 100644 --- a/gdb/testsuite/gdb.base/detach.exp +++ b/gdb/testsuite/gdb.base/detach.exp @@ -22,11 +22,6 @@ if { ! [istarget "*-*-linux*"] } { return 0 } -# Are we on a target board? -if [is_remote target] then { - return 0 -} - standard_testfile attach.c set escapedbinfile [string_to_regexp ${binfile}] -- 2.30.2