From 44896ba35b0874b9925ebd7927e196d0eb639b5e Mon Sep 17 00:00:00 2001 From: Gabe Black Date: Sat, 28 Oct 2017 00:36:13 -0700 Subject: [PATCH] base: Fix forcing loopback only binding for listeners. Despite online documentation, the type used for sin_addr.s_addr is not actually an unsigned long, it is an in_addr_t. When an unsigned long is a 64 bit value, the endian conversion moves the relevant bits of the 32 bit in_addr_t to positions which are truncated away. This forces the value to 0 which means to bind to any interface, the opposite of the intended effect. Change-Id: I53c63dea6bd88144dfef1a9a49b478fab30a8ba2 Reviewed-on: https://gem5-review.googlesource.com/5301 Reviewed-by: Andreas Sandberg Maintainer: Andreas Sandberg --- src/base/socket.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/base/socket.cc b/src/base/socket.cc index 5ef0f4b9e..a09b51fb2 100644 --- a/src/base/socket.cc +++ b/src/base/socket.cc @@ -106,7 +106,7 @@ ListenSocket::listen(int port, bool reuse) struct sockaddr_in sockaddr; sockaddr.sin_family = PF_INET; sockaddr.sin_addr.s_addr = - htobe(bindToLoopback ? INADDR_LOOPBACK : INADDR_ANY); + htobe(bindToLoopback ? INADDR_LOOPBACK : INADDR_ANY); sockaddr.sin_port = htons(port); // finally clear sin_zero memset(&sockaddr.sin_zero, 0, sizeof(sockaddr.sin_zero)); -- 2.30.2