From 44cb6d4df48bdc70a4a74befd4b88094b7edb06c Mon Sep 17 00:00:00 2001 From: Richard Guenther Date: Wed, 3 Nov 2010 16:58:50 +0000 Subject: [PATCH] re PR tree-optimization/46288 (ICE: SIGSEGV in walk_gimple_op (gimple.c:2857) with -O -fno-tree-dce and __builtin_expect()) 2010-11-03 Richard Guenther PR middle-end/46288 * predict.c (strip_predict_hints): Simply DCE builtin expect if the result is unused. * gcc.dg/pr46288.c: New testcase. From-SVN: r166258 --- gcc/ChangeLog | 6 ++++++ gcc/predict.c | 14 +++++++++++--- gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/gcc.dg/pr46288.c | 8 ++++++++ 4 files changed, 30 insertions(+), 3 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/pr46288.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 73198e3dc7a..e62aaabb410 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2010-11-03 Richard Guenther + + PR middle-end/46288 + * predict.c (strip_predict_hints): Simply DCE builtin expect if + the result is unused. + 2010-11-03 Jakub Jelinek PR tree-optimization/46009 diff --git a/gcc/predict.c b/gcc/predict.c index eb91b87819d..beceb0f2680 100644 --- a/gcc/predict.c +++ b/gcc/predict.c @@ -1329,9 +1329,17 @@ strip_predict_hints (void) && gimple_call_num_args (stmt) == 2) { var = gimple_call_lhs (stmt); - ass_stmt = gimple_build_assign (var, gimple_call_arg (stmt, 0)); - - gsi_replace (&bi, ass_stmt, true); + if (var) + { + ass_stmt + = gimple_build_assign (var, gimple_call_arg (stmt, 0)); + gsi_replace (&bi, ass_stmt, true); + } + else + { + gsi_remove (&bi, true); + continue; + } } } gsi_next (&bi); diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 5e266c1a8a4..61c24f9fb75 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2010-11-03 Richard Guenther + + PR middle-end/46288 + * gcc.dg/pr46288.c: New testcase. + 2010-11-03 Richard Guenther PR tree-optimization/44807 diff --git a/gcc/testsuite/gcc.dg/pr46288.c b/gcc/testsuite/gcc.dg/pr46288.c new file mode 100644 index 00000000000..24c8874fe00 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr46288.c @@ -0,0 +1,8 @@ +/* { dg-do compile } */ +/* { dg-options "-O -fno-tree-dce" } */ + +void foo (int i) +{ + __builtin_expect (i, i); +} + -- 2.30.2