From 4657573b80193b4716f3559b3bfef32fae0f974e Mon Sep 17 00:00:00 2001 From: Michal Ludvig Date: Tue, 7 May 2002 11:22:54 +0000 Subject: [PATCH] 2002-05-07 Michal Ludvig * dwarf2cfi.c: Code cleanup, removed unused variables, added default labels to switch {} statements. * x86-64-tdep.c: Ditto. * x86-64-linux-nat.c: Ditto. --- gdb/ChangeLog | 7 +++++++ gdb/dwarf2cfi.c | 17 +++++++++-------- gdb/x86-64-linux-nat.c | 6 ------ gdb/x86-64-tdep.c | 6 +++++- 4 files changed, 21 insertions(+), 15 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 9b583d3fd9f..2abbc4812c5 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,10 @@ +2002-05-07 Michal Ludvig + + * dwarf2cfi.c: Code cleanup, removed unused variables, + added default labels to switch {} statements. + * x86-64-tdep.c: Ditto. + * x86-64-linux-nat.c: Ditto. + 2002-05-07 Jason Thorpe * solib.h: Protect against multiple inclusion. diff --git a/gdb/dwarf2cfi.c b/gdb/dwarf2cfi.c index ffbeb5d95c1..a62a1e0f45d 100644 --- a/gdb/dwarf2cfi.c +++ b/gdb/dwarf2cfi.c @@ -222,8 +222,6 @@ static CORE_ADDR read_encoded_pointer (bfd *abfd, char **p, static LONGEST read_initial_length (bfd *abfd, char *buf, int *bytes_read); static ULONGEST read_length (bfd *abfd, char *buf, int *bytes_read, int dwarf64); -static ULONGEST read_address (bfd *abfd, char **p); - static int is_cie (ULONGEST cie_id, int dwarf64); static int compare_fde_unit (const void *a, const void *b); @@ -280,7 +278,7 @@ static struct context * context_alloc () { struct context *context; - struct context_reg *reg; + int regs_size = sizeof (struct context_reg) * NUM_REGS; context = (struct context *) obstack_alloc (&unwind_tmp_obstack, @@ -297,7 +295,7 @@ static struct frame_state * frame_state_alloc () { struct frame_state *fs; - struct frame_state_reg *reg; + int regs_size = sizeof (struct frame_state_reg) * NUM_REGS; fs = (struct frame_state *) obstack_alloc (&unwind_tmp_obstack, @@ -319,7 +317,6 @@ unwind_tmp_obstack_free () static void context_cpy (struct context *dst, struct context *src) { - struct context_reg *reg = dst->reg; int regs_size = sizeof (struct context_reg) * NUM_REGS; *dst = *src; @@ -586,7 +583,6 @@ execute_cfa_program ( struct objfile *objfile, char *insn_ptr, char *insn_end, unsigned char insn = *insn_ptr++; ULONGEST reg, uoffset; LONGEST offset; - int bytes_read; if (insn & DW_CFA_advance_loc) fs->pc += (insn & 0x3f) * fs->code_align; @@ -788,7 +784,6 @@ frame_state_for (struct context *context, struct frame_state *fs) { struct fde_unit *fde; struct cie_unit *cie; - unsigned char *aug, *insn, *end; context->args_size = 0; context->lsda = 0; @@ -1109,6 +1104,8 @@ execute_stack_op (struct objfile *objfile, case DW_OP_plus_uconst: result += read_uleb128 (objfile->obfd, &op_ptr); break; + default: + break; } break; @@ -1186,6 +1183,8 @@ execute_stack_op (struct objfile *objfile, case DW_OP_ne: result = (LONGEST) first != (LONGEST) second; break; + default: /* This label is here just to avoid warning. */ + break; } } break; @@ -1255,6 +1254,8 @@ update_context (struct context *context, struct frame_state *fs, int chain) exp + len, context, 0); break; } + default: + break; } context->cfa = cfa; @@ -1346,7 +1347,7 @@ compare_fde_unit (const void *a, const void *b) } /* Build the cie_chunks and fde_chunks tables from informations - in .debug.frame section. */ + in .debug_frame section. */ void dwarf2_build_frame_info (struct objfile *objfile) { diff --git a/gdb/x86-64-linux-nat.c b/gdb/x86-64-linux-nat.c index fd9246c2ea7..329532712d8 100644 --- a/gdb/x86-64-linux-nat.c +++ b/gdb/x86-64-linux-nat.c @@ -406,12 +406,6 @@ static struct core_fns linux_elf_core_fns = { #define offsetof(TYPE, MEMBER) ((unsigned long) &((TYPE *)0)->MEMBER) #endif -/* Record the value of the debug control register. */ -static long debug_control_mirror; - -/* Record which address associates with which register. */ -static CORE_ADDR address_lookup[DR_LASTADDR - DR_FIRSTADDR + 1]; - /* Return the address of register REGNUM. BLOCKEND is the value of u.u_ar0, which should point to the registers. */ CORE_ADDR diff --git a/gdb/x86-64-tdep.c b/gdb/x86-64-tdep.c index 50b0227136a..9cd9813752e 100644 --- a/gdb/x86-64-tdep.c +++ b/gdb/x86-64-tdep.c @@ -195,7 +195,7 @@ x86_64_register_convert_to_virtual (int regnum, struct type *type, char *from, char *to) { char buf[12]; - DOUBLEST d; + /* We only support floating-point values. */ if (TYPE_CODE (type) != TYPE_CODE_FLT) { @@ -426,6 +426,8 @@ classify_argument (struct type *type, } } break; + default: + break; } /* Final merger cleanup. */ for (i = 0; i < words; i++) @@ -488,6 +490,8 @@ classify_argument (struct type *type, } case TYPE_CODE_VOID: return 0; + default: /* Avoid warning. */ + break; } internal_error (__FILE__, __LINE__, "classify_argument: unknown argument type"); -- 2.30.2