From 4666cd04464f6f77a80b8d3479f8e4d5760d34fe Mon Sep 17 00:00:00 2001 From: Jason Merrill Date: Tue, 29 Aug 2006 02:55:35 -0400 Subject: [PATCH] re PR c++/26670 (attribute((packed)) sometimes not ignored for non-PODs) PR c++/26670 * class.c (check_field_decls): Unset TYPE_PACKED (t) if one of the fields can't be packed. From-SVN: r116555 --- gcc/cp/class.c | 11 +++++++---- gcc/testsuite/g++.dg/ext/packed11.C | 13 +++++++++++++ 2 files changed, 20 insertions(+), 4 deletions(-) create mode 100644 gcc/testsuite/g++.dg/ext/packed11.C diff --git a/gcc/cp/class.c b/gcc/cp/class.c index 18996a043b8..550edffaaab 100644 --- a/gcc/cp/class.c +++ b/gcc/cp/class.c @@ -2906,10 +2906,13 @@ check_field_decls (tree t, tree *access_decls, if (TYPE_PACKED (t)) { if (!pod_type_p (type) && !TYPE_PACKED (type)) - warning - (0, - "ignoring packed attribute on unpacked non-POD field %q+#D", - x); + { + warning + (0, + "ignoring packed attribute because of unpacked non-POD field %q+#D", + x); + TYPE_PACKED (t) = 0; + } else if (TYPE_ALIGN (TREE_TYPE (x)) > BITS_PER_UNIT) DECL_PACKED (x) = 1; } diff --git a/gcc/testsuite/g++.dg/ext/packed11.C b/gcc/testsuite/g++.dg/ext/packed11.C new file mode 100644 index 00000000000..e75845d9315 --- /dev/null +++ b/gcc/testsuite/g++.dg/ext/packed11.C @@ -0,0 +1,13 @@ +// PR c++/26670 + +struct nonpod { + nonpod(); +}; + +struct nonpod_pack { + nonpod n; // { dg-warning "ignoring packed attribute" } +} __attribute__ ((packed)); + +struct nonpod_pack2 { + nonpod_pack p; // { dg-warning "ignoring packed attribute" } +} __attribute__ ((packed)); -- 2.30.2