From 47a536d940d2f2bccfec51539b857da06ebc429e Mon Sep 17 00:00:00 2001 From: Sergio Durigan Junior Date: Thu, 29 Aug 2019 16:11:45 -0400 Subject: [PATCH] Remove "\nError: " suffix from nat/fork-inferior.c:trace_start_error warning message Rationale: https://sourceware.org/ml/gdb-patches/2019-08/msg00651.html This very simple patch removes the "\nError: " suffix from the warning message printed by nat/fork-inferior.c:trace_start_error. This proved to just pollute the screen, causing things like: Starting program: /usr/bin/true warning: Could not trace the inferior process. Error: warning: ptrace: Permission denied This "Error: " string is not useful at all, and can confuse things, therefore let's just remove it and simplify the resulting messages: Starting program: /usr/bin/true warning: Could not trace the inferior process. warning: ptrace: Permission denied gdb/ChangeLog: 2019-08-30 Sergio Durigan Junior * nat/fork-inferior.c (trace_start_error): Remove "\nError: " suffix from warning message. --- gdb/ChangeLog | 5 +++++ gdb/nat/fork-inferior.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 2cc7b5809e2..ebcfae1f977 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2019-08-30 Sergio Durigan Junior + + * nat/fork-inferior.c (trace_start_error): Remove "\nError: " + suffix from warning message. + 2019-08-30 Tom Tromey * tui/tui-winsource.h (struct tui_source_window_base) diff --git a/gdb/nat/fork-inferior.c b/gdb/nat/fork-inferior.c index 68b51aa8146..355e9bef430 100644 --- a/gdb/nat/fork-inferior.c +++ b/gdb/nat/fork-inferior.c @@ -580,7 +580,7 @@ trace_start_error (const char *fmt, ...) va_list ap; va_start (ap, fmt); - warning ("Could not trace the inferior process.\nError: "); + warning ("Could not trace the inferior process."); vwarning (fmt, ap); va_end (ap); -- 2.30.2