From 482155e6090a602cd31112d1e3f4e80d37fe6189 Mon Sep 17 00:00:00 2001 From: Tankut Baris Aktemur Date: Thu, 6 May 2021 15:15:13 +0200 Subject: [PATCH] gdbserver/server: make some functions void The 'handle_v_attach', 'handle_v_run', and 'handle_v_kill' functions' return values are unused. They indicate error/success result by putting packets. Make the functions void. Tested by rebuilding. gdbserver/ChangeLog: 2021-05-06 Tankut Baris Aktemur * server.cc (handle_v_attach) (handle_v_run) (handle_v_kill): Make void. --- gdbserver/ChangeLog | 6 ++++++ gdbserver/server.cc | 34 ++++++++++------------------------ 2 files changed, 16 insertions(+), 24 deletions(-) diff --git a/gdbserver/ChangeLog b/gdbserver/ChangeLog index 8ff59d1f486..94e489939c1 100644 --- a/gdbserver/ChangeLog +++ b/gdbserver/ChangeLog @@ -1,3 +1,9 @@ +2021-05-06 Tankut Baris Aktemur + + * server.cc (handle_v_attach) + (handle_v_run) + (handle_v_kill): Make void. + 2021-05-03 Tom Tromey PR build/27807: diff --git a/gdbserver/server.cc b/gdbserver/server.cc index a5d9f85216d..32dcc05924e 100644 --- a/gdbserver/server.cc +++ b/gdbserver/server.cc @@ -2973,8 +2973,8 @@ resume (struct thread_resume *actions, size_t num_actions) } } -/* Attach to a new program. Return 1 if successful, 0 if failure. */ -static int +/* Attach to a new program. */ +static void handle_v_attach (char *own_buf) { client_state &cs = get_client_state (); @@ -2998,18 +2998,13 @@ handle_v_attach (char *own_buf) } else prepare_resume_reply (own_buf, cs.last_ptid, &cs.last_status); - - return 1; } else - { - write_enn (own_buf); - return 0; - } + write_enn (own_buf); } -/* Run a new program. Return 1 if successful, 0 if failure. */ -static int +/* Run a new program. */ +static void handle_v_run (char *own_buf) { client_state &cs = get_client_state (); @@ -3106,7 +3101,7 @@ handle_v_run (char *own_buf) { write_enn (own_buf); free_vector_argv (new_argv); - return 0; + return; } } else @@ -3127,18 +3122,13 @@ handle_v_run (char *own_buf) query which is the main thread of the new inferior. */ if (non_stop) cs.general_thread = cs.last_ptid; - - return 1; } else - { - write_enn (own_buf); - return 0; - } + write_enn (own_buf); } -/* Kill process. Return 1 if successful, 0 if failure. */ -static int +/* Kill process. */ +static void handle_v_kill (char *own_buf) { client_state &cs = get_client_state (); @@ -3158,13 +3148,9 @@ handle_v_kill (char *own_buf) cs.last_ptid = ptid_t (pid); discard_queued_stop_replies (cs.last_ptid); write_ok (own_buf); - return 1; } else - { - write_enn (own_buf); - return 0; - } + write_enn (own_buf); } /* Handle all of the extended 'v' packets. */ -- 2.30.2