From 486499d044bfca617c7f3f7a0b0f6ae70ca98ef3 Mon Sep 17 00:00:00 2001 From: Christophe Lyon Date: Tue, 9 Feb 2010 14:44:50 +0000 Subject: [PATCH] 2010-02-08 Christophe Lyon gas/ * config/tc-arm.c (md_pcrel_from_section): Keep base to zero for non-local branches (BFD_RELOC_THUMB_PCREL_BRANCH23, BFD_RELOC_THUMB_PCREL_BLX, BFD_RELOC_ARM_PCREL_BLX, BFD_RELOC_ARM_PCREL_CALL) gas/testsuite/ * gas/arm/branch-reloc.s, gas/arm/branch-reloc.d, gas/arm/branch-reloc.l: New tests and expected results with all variants of call: ARM/Thumb, local/global, inter/intra-section, using BL/BLX. --- gas/ChangeLog | 7 +++ gas/config/tc-arm.c | 24 +++++--- gas/testsuite/ChangeLog | 7 +++ gas/testsuite/gas/arm/branch-reloc.d | 89 ++++++++++++++++++++++++++++ gas/testsuite/gas/arm/branch-reloc.l | 3 + gas/testsuite/gas/arm/branch-reloc.s | 87 +++++++++++++++++++++++++++ 6 files changed, 209 insertions(+), 8 deletions(-) create mode 100644 gas/testsuite/gas/arm/branch-reloc.d create mode 100644 gas/testsuite/gas/arm/branch-reloc.l create mode 100644 gas/testsuite/gas/arm/branch-reloc.s diff --git a/gas/ChangeLog b/gas/ChangeLog index 1dbdfb38ed1..294cc0cfd98 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,10 @@ +2010-02-08 Christophe Lyon + + * config/tc-arm.c (md_pcrel_from_section): Keep base to zero for + non-local branches (BFD_RELOC_THUMB_PCREL_BRANCH23, + BFD_RELOC_THUMB_PCREL_BLX, BFD_RELOC_ARM_PCREL_BLX, + BFD_RELOC_ARM_PCREL_CALL) + 2010-02-08 Sterling Augustine * config/tc-xtensa.c (frag_format_size): Generalize logic to diff --git a/gas/config/tc-arm.c b/gas/config/tc-arm.c index 7bf5416c993..2add8011d1d 100644 --- a/gas/config/tc-arm.c +++ b/gas/config/tc-arm.c @@ -19240,7 +19240,9 @@ md_pcrel_from_section (fixS * fixP, segT seg) return base + 4; case BFD_RELOC_THUMB_PCREL_BRANCH23: - if (fixP->fx_addsy + if (fixP->fx_addsy + && (S_GET_SEGMENT (fixP->fx_addsy) == seg) + && (!S_IS_EXTERNAL (fixP->fx_addsy)) && ARM_IS_FUNC (fixP->fx_addsy) && ARM_CPU_HAS_FEATURE (selected_cpu, arm_ext_v5t)) base = fixP->fx_where + fixP->fx_frag->fr_address; @@ -19248,8 +19250,10 @@ md_pcrel_from_section (fixS * fixP, segT seg) /* BLX is like branches above, but forces the low two bits of PC to zero. */ - case BFD_RELOC_THUMB_PCREL_BLX: - if (fixP->fx_addsy + case BFD_RELOC_THUMB_PCREL_BLX: + if (fixP->fx_addsy + && (S_GET_SEGMENT (fixP->fx_addsy) == seg) + && (!S_IS_EXTERNAL (fixP->fx_addsy)) && THUMB_IS_FUNC (fixP->fx_addsy) && ARM_CPU_HAS_FEATURE (selected_cpu, arm_ext_v5t)) base = fixP->fx_where + fixP->fx_frag->fr_address; @@ -19258,18 +19262,22 @@ md_pcrel_from_section (fixS * fixP, segT seg) /* ARM mode branches are offset by +8. However, the Windows CE loader expects the relocation not to take this into account. */ case BFD_RELOC_ARM_PCREL_BLX: - if (fixP->fx_addsy + if (fixP->fx_addsy + && (S_GET_SEGMENT (fixP->fx_addsy) == seg) + && (!S_IS_EXTERNAL (fixP->fx_addsy)) && ARM_IS_FUNC (fixP->fx_addsy) && ARM_CPU_HAS_FEATURE (selected_cpu, arm_ext_v5t)) base = fixP->fx_where + fixP->fx_frag->fr_address; - return base + 8; + return base + 8; - case BFD_RELOC_ARM_PCREL_CALL: - if (fixP->fx_addsy + case BFD_RELOC_ARM_PCREL_CALL: + if (fixP->fx_addsy + && (S_GET_SEGMENT (fixP->fx_addsy) == seg) + && (!S_IS_EXTERNAL (fixP->fx_addsy)) && THUMB_IS_FUNC (fixP->fx_addsy) && ARM_CPU_HAS_FEATURE (selected_cpu, arm_ext_v5t)) base = fixP->fx_where + fixP->fx_frag->fr_address; - return base + 8; + return base + 8; case BFD_RELOC_ARM_PCREL_BRANCH: case BFD_RELOC_ARM_PCREL_JUMP: diff --git a/gas/testsuite/ChangeLog b/gas/testsuite/ChangeLog index d875cfeba00..46139b79e01 100644 --- a/gas/testsuite/ChangeLog +++ b/gas/testsuite/ChangeLog @@ -1,3 +1,10 @@ +2010-02-08 Christophe Lyon + + * gas/arm/branch-reloc.s, gas/arm/branch-reloc.d, + gas/arm/branch-reloc.l: New tests and expected results with all + variants of call: ARM/Thumb, local/global, inter/intra-section, + using BL/BLX. + 2010-02-08 Christophe Lyon * gas/arm/arm-it-auto.d: Update expected results. diff --git a/gas/testsuite/gas/arm/branch-reloc.d b/gas/testsuite/gas/arm/branch-reloc.d new file mode 100644 index 00000000000..6ba322e5a9c --- /dev/null +++ b/gas/testsuite/gas/arm/branch-reloc.d @@ -0,0 +1,89 @@ +#name: Inter-section branch relocations +#This test is only valid on ELF based ports. +#not-target: *-*-*coff *-*-pe *-*-wince *-*-*aout* *-*-netbsd *-*-riscix* +#as: -march=armv5t +#objdump: -rd +#stderr: branch-reloc.l + +# Test the generation of relocation for inter-section branches + +.*: +file format.*arm.* + + +Disassembly of section .text: + +00000000 : + 0: e1a00000 nop ; \(mov r0, r0\) + +00000004 : + 4: ebfffffe bl 46 + 4: R_ARM_CALL thumb_glob_sym1 + 8: ebfffffe bl 100 + 8: R_ARM_CALL thumb_glob_sym2 + c: fa00000c blx 44 + 10: ebfffffe bl 4 + 10: R_ARM_CALL arm_glob_sym1 + 14: ebfffffe bl 13c + 14: R_ARM_CALL arm_glob_sym2 + 18: eb000007 bl 3c + 1c: fafffffe blx 46 + 1c: R_ARM_CALL thumb_glob_sym1 + 20: fafffffe blx 100 + 20: R_ARM_CALL thumb_glob_sym2 + 24: fa000006 blx 44 + 28: fafffffe blx 4 + 28: R_ARM_CALL arm_glob_sym1 + 2c: fafffffe blx 13c + 2c: R_ARM_CALL arm_glob_sym2 + 30: eb000001 bl 3c + 34: e1a00000 nop ; \(mov r0, r0\) + 38: e12fff1e bx lr + +0000003c : + 3c: e1a00000 nop ; \(mov r0, r0\) + 40: e12fff1e bx lr + +00000044 : + 44: 4770 bx lr + +00000046 : + 46: 4770 bx lr + +Disassembly of section foo: + +00000000 : + ... + +00000100 : + 100: f7ff fffe bl 4 + 100: R_ARM_THM_CALL arm_glob_sym1 + 104: f7ff fffe bl 13c + 104: R_ARM_THM_CALL arm_glob_sym2 + 108: f000 e816 blx 138 + 10c: f7ff fffe bl 46 + 10c: R_ARM_THM_CALL thumb_glob_sym1 + 110: f7ff fffe bl 100 + 110: R_ARM_THM_CALL thumb_glob_sym2 + 114: f000 f80e bl 134 + 118: f7ff effe blx 4 + 118: R_ARM_THM_CALL arm_glob_sym1 + 11c: f7ff effe blx 13c + 11c: R_ARM_THM_CALL arm_glob_sym2 + 120: f000 e80a blx 138 + 124: f7ff effe blx 46 + 124: R_ARM_THM_CALL thumb_glob_sym1 + 128: f7ff effe blx 100 + 128: R_ARM_THM_CALL thumb_glob_sym2 + 12c: f000 f802 bl 134 + 130: 46c0 nop ; \(mov r8, r8\) + 132: 4770 bx lr + +00000134 : + 134: 46c0 nop ; \(mov r8, r8\) + 136: 4770 bx lr + +00000138 : + 138: e12fff1e bx lr + +0000013c : + 13c: e12fff1e bx lr diff --git a/gas/testsuite/gas/arm/branch-reloc.l b/gas/testsuite/gas/arm/branch-reloc.l new file mode 100644 index 00000000000..293cfe014e2 --- /dev/null +++ b/gas/testsuite/gas/arm/branch-reloc.l @@ -0,0 +1,3 @@ +[^:]*: Assembler messages: +[^:]*:[0-9]*: Warning: blx to 'arm_sym1' an ARM ISA state function changed to bl +[^:]*:[0-9]*: Warning: blx to Thumb func 'thumb_sym2' from Thumb ISA state changed to bl \ No newline at end of file diff --git a/gas/testsuite/gas/arm/branch-reloc.s b/gas/testsuite/gas/arm/branch-reloc.s new file mode 100644 index 00000000000..b01146e20d0 --- /dev/null +++ b/gas/testsuite/gas/arm/branch-reloc.s @@ -0,0 +1,87 @@ +@ Check that non-local branches with and without mode switching +@ produce the right relocations with appropriate in-place addends. + + .syntax unified + + .text + .arm + .global arm_glob_sym1 + .global arm_glob_sym2 + .global thumb_glob_sym1 + .global thumb_glob_sym2 + nop + .type arm_glob_sym1, %function +arm_glob_sym1: + bl thumb_glob_sym1 + bl thumb_glob_sym2 + bl thumb_sym1 + bl arm_glob_sym1 + bl arm_glob_sym2 + bl arm_sym1 + blx thumb_glob_sym1 + blx thumb_glob_sym2 + blx thumb_sym1 + blx arm_glob_sym1 + blx arm_glob_sym2 + blx arm_sym1 + nop + bx lr + + .type arm_sym1, %function +arm_sym1: + nop + bx lr + + .thumb + .thumb_func + .type thumb_sym1, %function +thumb_sym1: + bx lr + + .type thumb_glob_sym1, %function + .thumb_func + .thumb +thumb_glob_sym1: + bx lr + + .section foo,"ax" + +@ Add some space to avoid confusing objdump output: as we are +@ producing a relocatable file, objdump may match an address to +@ the wrong symbol (as symbols in different sections may have the same +@ address in the object file). + .space 0x100 + + .type thumb_glob_sym2, %function + .thumb_func + .thumb +thumb_glob_sym2: + bl arm_glob_sym1 + bl arm_glob_sym2 + bl arm_sym2 + bl thumb_glob_sym1 + bl thumb_glob_sym2 + bl thumb_sym2 + blx arm_glob_sym1 + blx arm_glob_sym2 + blx arm_sym2 + blx thumb_glob_sym1 + blx thumb_glob_sym2 + blx thumb_sym2 + nop + bx lr + + .type thumb_sym2, %function +thumb_sym2: + nop + bx lr + + .arm + .type arm_sym2, %function +arm_sym2: + bx lr + + .global arm_glob_sym2 + .type arm_glob_sym2, %function +arm_glob_sym2: + bx lr -- 2.30.2