From 4872de4ac72b4687c805a2c370de1095b6429580 Mon Sep 17 00:00:00 2001 From: Joseph Myers Date: Fri, 23 Aug 2019 22:04:33 +0100 Subject: [PATCH] Fix libstdc++ lstat missing return type for Windows target. Building for i686-mingw32 target (with some local changes) produced an error error: ISO C++ forbids declaration of 'lstat' with no type [-fpermissive] in libstdc++-v3/src/filesystem/ops-common.h. This patch adds the missing return type. OK to commit (trunk and GCC 9 branch)? Note 1: I haven't run the testsuite with this patch, but it fixes the build failure I see (in sources with other local changes). Note 2: I don't know why this hasn't produced build failures for other people, but the missing return type looks wrong in any case even if other local changes are for some reason needed for it to produce an error. * src/filesystem/ops-common.h [_GLIBCXX_FILESYSTEM_IS_WINDOWS] (std::filesystem::__gnu_posix::lstat): Add return type. From-SVN: r274885 --- libstdc++-v3/ChangeLog | 5 +++++ libstdc++-v3/src/filesystem/ops-common.h | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog index d1c651d46fc..e1e109ce723 100644 --- a/libstdc++-v3/ChangeLog +++ b/libstdc++-v3/ChangeLog @@ -1,3 +1,8 @@ +2019-08-23 Joseph Myers + + * src/filesystem/ops-common.h [_GLIBCXX_FILESYSTEM_IS_WINDOWS] + (std::filesystem::__gnu_posix::lstat): Add return type. + 2019-08-20 Jonathan Wakely * doc/doxygen/user.cfg.in (INPUT): Remove profile mode headers. diff --git a/libstdc++-v3/src/filesystem/ops-common.h b/libstdc++-v3/src/filesystem/ops-common.h index 6dc9b137dbf..21d0bbabb43 100644 --- a/libstdc++-v3/src/filesystem/ops-common.h +++ b/libstdc++-v3/src/filesystem/ops-common.h @@ -76,7 +76,7 @@ namespace __gnu_posix inline int stat(const wchar_t* path, stat_type* buffer) { return ::_wstat(path, buffer); } - inline lstat(const wchar_t* path, stat_type* buffer) + inline int lstat(const wchar_t* path, stat_type* buffer) { // TODO symlinks not currently supported return stat(path, buffer); -- 2.30.2