From 48ab418ec75e8b1cbea3e1561de6ec634dad2bf3 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Sat, 20 Oct 2018 12:30:00 -0600 Subject: [PATCH] Make "all" depend on "info" I've broken "make info" a couple of times now, because I sometimes forget to run "make info" after modifying a Texinfo file. I don't know why gdb's "make all" doesn't build the info pages. I suspect this was some Cygnus-local oddity back in the day. This patch changes doc/Makefile.in so that the info pages are built by "make all". As a point of reference, Automake has essentially always worked this way. According to the Automake manual (I didn't double-check) this is required by the GNU coding standards. The first time I sent this patch, I mentioned that I wanted to look into some existing bugs in bugzilla about missing "makeinfo". However, today I tried and I discovered that BFD requires makeinfo, and builds its info file as part of "all". So, I think this change doesn't worsen the situation for users in any way, and can simply go in. gdb/doc/ChangeLog 2019-04-07 Tom Tromey * Makefile.in (all): Depend on "info". --- gdb/doc/ChangeLog | 4 ++++ gdb/doc/Makefile.in | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog index ea5fafdff1a..5a0621e2ceb 100644 --- a/gdb/doc/ChangeLog +++ b/gdb/doc/ChangeLog @@ -1,3 +1,7 @@ +2019-04-07 Tom Tromey + + * Makefile.in (all): Depend on "info". + 2019-04-01 Andrew Burgess * gdb.texinfo (Convenience Funs): Document '$_creal' and diff --git a/gdb/doc/Makefile.in b/gdb/doc/Makefile.in index 39c94dc82bc..2bb8a3051bb 100644 --- a/gdb/doc/Makefile.in +++ b/gdb/doc/Makefile.in @@ -182,7 +182,7 @@ HAVE_NATIVE_GCORE_TARGET = @HAVE_NATIVE_GCORE_TARGET@ ### -all: +all: info info: $(INFO_DEPS) dvi: gdb.dvi stabs.dvi refcard.dvi annotate.dvi -- 2.30.2