From 48e4f473eb23e4bf95e517f9eb83272316674c16 Mon Sep 17 00:00:00 2001 From: Oleg Endo Date: Mon, 26 Jan 2015 23:56:05 +0000 Subject: [PATCH] re PR target/49263 (SH Target: underutilized "TST #imm, R0" instruction) gcc/ PR target/49263 * config/sh/sh.c (sh_split_treg_set_expr): Invoke emit_insn before remove_insn. * config/sh/sh.md (tstsi_t): Don't try to optimize constant with right shifts if it already fits into K08. gcc/testsuite/ PR target/49263 * gcc.target/sh/pr49263-4.c: New. From-SVN: r220144 --- gcc/ChangeLog | 8 ++++++++ gcc/config/sh/sh.c | 4 ++-- gcc/config/sh/sh.md | 8 ++++++-- gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/gcc.target/sh/pr49263-4.c | 10 ++++++++++ 5 files changed, 31 insertions(+), 4 deletions(-) create mode 100644 gcc/testsuite/gcc.target/sh/pr49263-4.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 8cf5d5b104a..e44eb7360af 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,11 @@ +2015-01-26 Oleg Endo + + PR target/49263 + * config/sh/sh.c (sh_split_treg_set_expr): Invoke emit_insn before + remove_insn. + * config/sh/sh.md (tstsi_t): Don't try to optimize constant with right + shifts if it already fits into K08. + 2015-01-26 Jakub Jelinek PR ipa/64730 diff --git a/gcc/config/sh/sh.c b/gcc/config/sh/sh.c index 7d07634abe3..a7427f56288 100644 --- a/gcc/config/sh/sh.c +++ b/gcc/config/sh/sh.c @@ -14466,6 +14466,8 @@ sh_split_treg_set_expr (rtx x, rtx_insn* curr_insn) fprintf (dump_file, "trailing nott insn %d\n", INSN_UID (nott_insn)); } + emit_insn (insnlist.first); + if (nott_insn != NULL && append_nott) { if (dump_file) @@ -14475,8 +14477,6 @@ sh_split_treg_set_expr (rtx x, rtx_insn* curr_insn) append_nott = false; } - emit_insn (insnlist.first); - if (append_nott) nott_insn = emit_insn (gen_nott (get_t_reg_rtx ())); diff --git a/gcc/config/sh/sh.md b/gcc/config/sh/sh.md index 956d1ef672e..4a39e12d8db 100644 --- a/gcc/config/sh/sh.md +++ b/gcc/config/sh/sh.md @@ -742,8 +742,12 @@ variant instead and load the constant into a reg. For that we'd need to do some analysis. */ - if ((op1val & 0xFFFF) == 0 - && CONST_OK_FOR_K08 (op1val >> 16) && optimize_size) + if (CONST_OK_FOR_K08 (op1val)) + { + /* Do nothing. */ + } + else if ((op1val & 0xFFFF) == 0 + && CONST_OK_FOR_K08 (op1val >> 16) && optimize_size) { /* Use a swap.w insn to do a shift + reg copy (to R0) in one insn. */ op1val = op1val >> 16; diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index cf72ea92648..c66df2007d6 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2015-01-26 Oleg Endo + + PR target/49263 + * gcc.target/sh/pr49263-4.c: New. + 2015-01-26 Paul Thomas PR fortran/62044 diff --git a/gcc/testsuite/gcc.target/sh/pr49263-4.c b/gcc/testsuite/gcc.target/sh/pr49263-4.c new file mode 100644 index 00000000000..cbba68b88f0 --- /dev/null +++ b/gcc/testsuite/gcc.target/sh/pr49263-4.c @@ -0,0 +1,10 @@ +/* Verify that TST #imm, R0 instruction is generated if the constant + allows it when compiling for -Os. */ +/* { dg-do compile } */ +/* { dg-options "-Os" } */ +/* { dg-final { scan-assembler-not "and" } } */ +/* { dg-final { scan-assembler-not "extu" } } */ +/* { dg-final { scan-assembler-not "exts" } } */ +/* { dg-final { scan-assembler-not "shlr" } } */ + +#include "pr49263.c" -- 2.30.2