From 492585555776bb6f51bb623c34218b7c17cdb2a4 Mon Sep 17 00:00:00 2001 From: Andreas Sandberg Date: Mon, 24 Aug 2020 17:55:45 +0100 Subject: [PATCH] dev: Use the new ByteOrder param type in SimpleUart Use the new ByteOrder param type in SimpleUart. The default value is currently little endian. However, it is expected that most users of this device will use single-byte accesses which aren't affected by endianness. Change-Id: I3f5d4ea566e5127474cff976332bd53c5b49b9e2 Signed-off-by: Andreas Sandberg Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/33295 Tested-by: kokoro Reviewed-by: Giacomo Travaglini --- src/dev/serial/Uart.py | 2 +- src/dev/serial/simple.cc | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/dev/serial/Uart.py b/src/dev/serial/Uart.py index 97efcdd46..7955d6916 100644 --- a/src/dev/serial/Uart.py +++ b/src/dev/serial/Uart.py @@ -52,7 +52,7 @@ class Uart(BasicPioDevice): class SimpleUart(Uart): type = 'SimpleUart' cxx_header = "dev/serial/simple.hh" - big_endian = Param.Bool(False, "Is the device Big Endian?") + byte_order = Param.ByteOrder("little", "Device byte order") pio_size = Param.Addr(0x4, "Size of address range") end_on_eot = Param.Bool(False, "End the simulation when a EOT is "\ "received on the UART") diff --git a/src/dev/serial/simple.cc b/src/dev/serial/simple.cc index 97018abbe..339d6b96d 100644 --- a/src/dev/serial/simple.cc +++ b/src/dev/serial/simple.cc @@ -43,9 +43,7 @@ #include "sim/sim_exit.hh" SimpleUart::SimpleUart(const SimpleUartParams *p) - : Uart(p, p->pio_size), - byteOrder(p->big_endian ? ByteOrder::big : ByteOrder::little), - endOnEOT(p->end_on_eot) + : Uart(p, p->pio_size), byteOrder(p->byte_order), endOnEOT(p->end_on_eot) { } -- 2.30.2