From 49dd3b803d8baee268321a76a03c2b4e6accdae9 Mon Sep 17 00:00:00 2001 From: Luke Kenneth Casson Leighton Date: Sun, 31 May 2020 19:46:44 +0100 Subject: [PATCH] imports - use of globals. baaaad --- src/soc/fu/compunits/test/test_alu_compunit.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/soc/fu/compunits/test/test_alu_compunit.py b/src/soc/fu/compunits/test/test_alu_compunit.py index 6041cd3e..f81aa736 100644 --- a/src/soc/fu/compunits/test/test_alu_compunit.py +++ b/src/soc/fu/compunits/test/test_alu_compunit.py @@ -1,7 +1,10 @@ import unittest from soc.decoder.power_enums import (XER_bits,) -from soc.fu.alu.test.test_pipe_caller import TestCase, ALUTestCase, test_data +# XXX bad practice: use of global variables +from soc.fu.alu.test.test_pipe_caller import ALUTestCase # creates the tests +from soc.fu.alu.test.test_pipe_caller import test_data # imports the data + from soc.fu.compunits.compunits import ALUFunctionUnit from soc.fu.compunits.test.test_compunit import TestRunner -- 2.30.2