From 4a0c24f2dd97c670259a7ab0ced701dbf9bb5dd7 Mon Sep 17 00:00:00 2001 From: Timothy Arceri Date: Wed, 13 Dec 2017 18:46:56 +1100 Subject: [PATCH] ac: rework ac_llvm_extract_elem() MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Simplifies the logic a little and asserts index is 0. Suggested-by: Nicolai Hähnle Reviewed-by: Marek Olšák --- src/amd/common/ac_llvm_build.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index 0ea5e7f4caa..8a3a2abf17b 100644 --- a/src/amd/common/ac_llvm_build.c +++ b/src/amd/common/ac_llvm_build.c @@ -114,10 +114,10 @@ ac_llvm_extract_elem(struct ac_llvm_context *ac, LLVMValueRef value, int index) { - int count = ac_get_llvm_num_components(value); - - if (count == 1) + if (LLVMGetTypeKind(LLVMTypeOf(value)) != LLVMVectorTypeKind) { + assert(index == 0); return value; + } return LLVMBuildExtractElement(ac->builder, value, LLVMConstInt(ac->i32, index, false), ""); -- 2.30.2