From 4a5700b62f767ed08c97122bad182244700bb4e3 Mon Sep 17 00:00:00 2001 From: Mark Wielaard Date: Wed, 26 Aug 2020 21:46:04 +0200 Subject: [PATCH] gas: Handle bad -gdwarf options, just like bad --gdwarf options. parse_args uses getopt_long_only so it can handle long options both with double and single dash. But this means that some single dash options like -gdwarf-1 don't generate an error (unlike --gdwarf-1). This is especially confusing since there is also --gdwarf2, but no --gdwarf4 (it is --gdwarf-4). When giving -gdwarf4 the option is silently interpreted as -g (which set dwarf_version to 2). This causes some confusion for people who don't expect this and suddenly get DWARF2 instead of DWARF4 as they might expect. So make it so that the -gdwarf creates an error, just like --gdwarf would. --- gas/ChangeLog | 4 ++++ gas/as.c | 7 +++++++ 2 files changed, 11 insertions(+) diff --git a/gas/ChangeLog b/gas/ChangeLog index 8d3a92f1138..63d1596eba4 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,7 @@ +2020-08-26 Mark Wielaard + + * as.c (parse_args): Handle bad -gdwarf options. + 2020-08-28 Cooper Qu * gas/config/tc-csky.c (md_begin): Set attributes. diff --git a/gas/as.c b/gas/as.c index a703d7a6727..eda75945238 100644 --- a/gas/as.c +++ b/gas/as.c @@ -816,6 +816,13 @@ This program has absolutely no warranty.\n")); && md_parse_option (optc, optarg)) continue; + /* We end up here for any -gsomething-not-already-a-long-option. + give some useful feedback on not (yet) supported -gdwarfxxx + versions/sections/options. */ + if (strncmp (old_argv[optind - 1], "-gdwarf", + strlen ("-gdwarf")) == 0) + as_fatal (_("unknown DWARF option %s\n"), old_argv[optind - 1]); + if (md_debug_format_selector) debug_type = md_debug_format_selector (& use_gnu_debug_info_extensions); else if (IS_ELF) -- 2.30.2