From 4aef764338ed40a7fa9573b0e6e2ade817acd688 Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Sat, 11 Mar 2017 20:56:51 +1030 Subject: [PATCH] Remove bogus ATTRIBUTE_UNUSED * elf32-ppc.c: Remove ATTRIBUTE_UNUSED throughout when function parameter is in fact used. Whitespace fixes. * elf64-ppc.c: Likewise. --- bfd/ChangeLog | 6 ++++++ bfd/elf32-ppc.c | 26 +++++++++++++------------- bfd/elf64-ppc.c | 6 +++--- 3 files changed, 22 insertions(+), 16 deletions(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 0fcaa3b83d6..277e552d4ee 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,9 @@ +2017-03-11 Alan Modra + + * elf32-ppc.c: Remove ATTRIBUTE_UNUSED throughout when function + parameter is in fact used. Whitespace fixes. + * elf64-ppc.c: Likewise. + 2017-03-09 Sam Thursfield * rs6000-core.c (CORE_NEW): Simplify macro when diff --git a/bfd/elf32-ppc.c b/bfd/elf32-ppc.c index da0030fddf4..72ead480c29 100644 --- a/bfd/elf32-ppc.c +++ b/bfd/elf32-ppc.c @@ -2045,7 +2045,7 @@ ppc_elf_reloc_name_lookup (bfd *abfd ATTRIBUTE_UNUSED, /* Set the howto pointer for a PowerPC ELF reloc. */ static void -ppc_elf_info_to_howto (bfd *abfd ATTRIBUTE_UNUSED, +ppc_elf_info_to_howto (bfd *abfd, arelent *cache_ptr, Elf_Internal_Rela *dst) { @@ -2082,10 +2082,10 @@ ppc_elf_info_to_howto (bfd *abfd ATTRIBUTE_UNUSED, /* Handle the R_PPC_ADDR16_HA and R_PPC_REL16_HA relocs. */ static bfd_reloc_status_type -ppc_elf_addr16_ha_reloc (bfd *abfd ATTRIBUTE_UNUSED, +ppc_elf_addr16_ha_reloc (bfd *abfd, arelent *reloc_entry, asymbol *symbol, - void *data ATTRIBUTE_UNUSED, + void *data, asection *input_section, bfd *output_bfd, char **error_message ATTRIBUTE_UNUSED) @@ -2648,7 +2648,7 @@ static struct bfd_elf_special_section ppc_alt_plt = { STRING_COMMA_LEN (".plt"), 0, SHT_PROGBITS, SHF_ALLOC }; static const struct bfd_elf_special_section * -ppc_elf_get_sec_type_attr (bfd *abfd ATTRIBUTE_UNUSED, asection *sec) +ppc_elf_get_sec_type_attr (bfd *abfd, asection *sec) { const struct bfd_elf_special_section *ssect; @@ -8250,7 +8250,7 @@ ppc_elf_relocate_section (bfd *output_bfd, wrel->r_info = ELF32_R_INFO (0, R_PPC_ADDR16_HA); wrel->r_addend = got_addr; insn &= ~0xffff; - insn |= ((unsigned int )(got_addr + 0x8000) >> 16) & 0xffff; + insn |= ((unsigned int) (got_addr + 0x8000) >> 16) & 0xffff; bfd_put_32 (input_bfd, insn, p); /* Convert lis to lwz, loading address from GOT. */ @@ -10990,7 +10990,7 @@ ppc_elf_finish_dynamic_sections (bfd *output_bfd, /* VxWorks uses the elf default section flags for .plt. */ static const struct bfd_elf_special_section * -ppc_elf_vxworks_get_sec_type_attr (bfd *abfd ATTRIBUTE_UNUSED, asection *sec) +ppc_elf_vxworks_get_sec_type_attr (bfd *abfd, asection *sec) { if (sec->name == NULL) return NULL; @@ -11027,23 +11027,23 @@ static bfd_boolean ppc_elf_vxworks_add_symbol_hook (bfd *abfd, struct bfd_link_info *info, Elf_Internal_Sym *sym, - const char **namep ATTRIBUTE_UNUSED, - flagword *flagsp ATTRIBUTE_UNUSED, + const char **namep, + flagword *flagsp, asection **secp, bfd_vma *valp) { - if (!elf_vxworks_add_symbol_hook(abfd, info, sym,namep, flagsp, secp, - valp)) + if (!elf_vxworks_add_symbol_hook (abfd, info, sym, namep, flagsp, secp, + valp)) return FALSE; - return ppc_elf_add_symbol_hook(abfd, info, sym,namep, flagsp, secp, valp); + return ppc_elf_add_symbol_hook (abfd, info, sym, namep, flagsp, secp, valp); } static void ppc_elf_vxworks_final_write_processing (bfd *abfd, bfd_boolean linker) { - ppc_elf_final_write_processing(abfd, linker); - elf_vxworks_final_write_processing(abfd, linker); + ppc_elf_final_write_processing (abfd, linker); + elf_vxworks_final_write_processing (abfd, linker); } /* On VxWorks, we emit relocations against _PROCEDURE_LINKAGE_TABLE_, so diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c index d0673c91878..c9a3f2121bb 100644 --- a/bfd/elf64-ppc.c +++ b/bfd/elf64-ppc.c @@ -2499,7 +2499,7 @@ ppc64_elf_reloc_name_lookup (bfd *abfd ATTRIBUTE_UNUSED, /* Set the howto pointer for a PowerPC ELF reloc. */ static void -ppc64_elf_info_to_howto (bfd *abfd ATTRIBUTE_UNUSED, arelent *cache_ptr, +ppc64_elf_info_to_howto (bfd *abfd, arelent *cache_ptr, Elf_Internal_Rela *dst) { unsigned int type; @@ -4278,7 +4278,7 @@ static hashval_t tocsave_htab_hash (const void *p) { const struct tocsave_entry *e = (const struct tocsave_entry *) p; - return ((bfd_vma)(intptr_t) e->sec ^ e->offset) >> 3; + return ((bfd_vma) (intptr_t) e->sec ^ e->offset) >> 3; } static int @@ -15400,7 +15400,7 @@ static bfd_boolean ppc64_elf_finish_dynamic_symbol (bfd *output_bfd, struct bfd_link_info *info, struct elf_link_hash_entry *h, - Elf_Internal_Sym *sym ATTRIBUTE_UNUSED) + Elf_Internal_Sym *sym) { struct ppc_link_hash_table *htab; struct plt_entry *ent; -- 2.30.2