From 4b0f07110e55b09f44ef95a36e4d7ca4612de33c Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Wed, 17 Mar 2010 13:46:35 +0000 Subject: [PATCH] Avoid overflow. 2010-03-17 Jie Zhang * elf.c (assign_file_positions_for_load_sections): Avoid overflow. --- bfd/ChangeLog | 5 +++++ bfd/elf.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 1008a6619a1..bcfae55e8b1 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,8 @@ +2010-03-17 Jie Zhang + + * elf.c (assign_file_positions_for_load_sections): Avoid + overflow. + 2010-03-17 Alan Modra * plugin.c (bfd_plugin_object_p): Pass iostream to fileno using diff --git a/bfd/elf.c b/bfd/elf.c index dbb13d4d765..cee9b7a4455 100644 --- a/bfd/elf.c +++ b/bfd/elf.c @@ -4452,7 +4452,7 @@ assign_file_positions_for_load_sections (bfd *abfd, { bfd_signed_vma adjust = sec->vma - (p->p_vaddr + p->p_memsz); - if (adjust < 0) + if (sec->vma < p->p_vaddr + p->p_memsz) { (*_bfd_error_handler) (_("%B: section %A vma 0x%lx overlaps previous sections"), -- 2.30.2