From 4ca3de06ec35e5f72827b0cc61a4119e53500681 Mon Sep 17 00:00:00 2001 From: Erico Nunes Date: Wed, 22 Jan 2020 00:37:22 +0100 Subject: [PATCH] lima/ppir: fix ssa undef emit The ssa doesn't need to be manually added to block->comp->reg_list. Doing so actually causes other registers to be marked as undef=true later. This patch alone fixes a few deqp tests that have undefs. Signed-off-by: Erico Nunes Reviewed-by: Vasily Khoruzhick Part-of: --- .gitlab-ci/deqp-lima-fails.txt | 5 ----- src/gallium/drivers/lima/ir/pp/nir.c | 3 --- 2 files changed, 8 deletions(-) diff --git a/.gitlab-ci/deqp-lima-fails.txt b/.gitlab-ci/deqp-lima-fails.txt index c298e8b7f44..c85e28b4cc9 100644 --- a/.gitlab-ci/deqp-lima-fails.txt +++ b/.gitlab-ci/deqp-lima-fails.txt @@ -77,11 +77,6 @@ dEQP-GLES2.functional.shaders.functions.qualifiers.out_lowp_int_vertex dEQP-GLES2.functional.shaders.indexing.matrix_subscript.mat3_dynamic_loop_write_static_loop_read_vertex dEQP-GLES2.functional.shaders.indexing.matrix_subscript.mat3_dynamic_loop_write_static_read_vertex dEQP-GLES2.functional.shaders.indexing.matrix_subscript.mat3_dynamic_write_dynamic_loop_read_vertex -dEQP-GLES2.functional.shaders.indexing.vector_subscript.vec2_dynamic_subscript_write_component_read_fragment -dEQP-GLES2.functional.shaders.indexing.vector_subscript.vec2_dynamic_subscript_write_direct_read_fragment -dEQP-GLES2.functional.shaders.indexing.vector_subscript.vec2_dynamic_subscript_write_dynamic_loop_subscript_read_fragment -dEQP-GLES2.functional.shaders.indexing.vector_subscript.vec2_dynamic_subscript_write_static_loop_subscript_read_fragment -dEQP-GLES2.functional.shaders.indexing.vector_subscript.vec2_dynamic_subscript_write_static_subscript_read_fragment dEQP-GLES2.functional.shaders.loops.do_while_constant_iterations.conditional_body_vertex dEQP-GLES2.functional.shaders.loops.do_while_dynamic_iterations.vector_counter_fragment dEQP-GLES2.functional.shaders.loops.do_while_uniform_iterations.conditional_body_vertex diff --git a/src/gallium/drivers/lima/ir/pp/nir.c b/src/gallium/drivers/lima/ir/pp/nir.c index 0c91c09831b..9798d16dd1e 100644 --- a/src/gallium/drivers/lima/ir/pp/nir.c +++ b/src/gallium/drivers/lima/ir/pp/nir.c @@ -440,9 +440,6 @@ static ppir_node *ppir_emit_ssa_undef(ppir_block *block, nir_instr *ni) ppir_dest *dest = &alu->dest; dest->ssa.undef = true; - ppir_reg *ssa = &dest->ssa; - - list_add(&ssa->list, &block->comp->reg_list); return node; } -- 2.30.2