From 4cb1265b3f906cbfd092715b61bb81a8f6179a49 Mon Sep 17 00:00:00 2001 From: Mihails Strasuns Date: Wed, 16 Dec 2020 20:36:15 +0100 Subject: [PATCH] bfd: add elfcore_write_file_note Adds a trivial wrapper over elfcore_write_note, primarily to be more consistent with other ELF note helper functions and highlight NT_FILE as one of notes handled by gdb. bfd/ChangeLog: 2020-12-17 Mihails Strasuns * bfd-elf.h (elfcore_write_file_note): New function. * elf.c (elfcore_write_file_note): New function. gdb/ChangeLog: 2020-12-17 Mihails Strasuns * linux-tdep.c (linux_make_mappings_corefile_notes): Start using elfcore_write_file_note. --- bfd/ChangeLog | 5 +++++ bfd/elf-bfd.h | 2 ++ bfd/elf.c | 8 ++++++++ gdb/ChangeLog | 5 +++++ gdb/linux-tdep.c | 8 +++----- 5 files changed, 23 insertions(+), 5 deletions(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 96b9cdf2452..c8fcb3a6845 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,8 @@ +2020-12-17 Mihails Strasuns + + * bfd-elf.h (elfcore_write_file_note): New function. + * elf.c (elfcore_write_file_note): New function. + 2021-01-26 Alan Modra * elf32-ft32.c (ft32_reloc_type_lookup): Don't miss ft32_reloc_map[0]. diff --git a/bfd/elf-bfd.h b/bfd/elf-bfd.h index 15206b4e876..994f15e48cf 100644 --- a/bfd/elf-bfd.h +++ b/bfd/elf-bfd.h @@ -2801,6 +2801,8 @@ extern char *elfcore_write_lwpstatus (bfd *, char *, int *, long, int, const void *); extern char *elfcore_write_register_note (bfd *, char *, int *, const char *, const void *, int); +extern char *elfcore_write_file_note + (bfd *, char *, int *, const void*, int); /* Internal structure which holds information to be included in the PRPSINFO section of Linux core files. diff --git a/bfd/elf.c b/bfd/elf.c index 84a5d942817..087f05e5cc8 100644 --- a/bfd/elf.c +++ b/bfd/elf.c @@ -12038,6 +12038,14 @@ elfcore_write_register_note (bfd *abfd, return NULL; } +char * +elfcore_write_file_note (bfd *obfd, char *note_data, int *note_size, + const void *buf, int bufsiz) +{ + return elfcore_write_note (obfd, note_data, note_size, + "CORE", NT_FILE, buf, bufsiz); +} + static bfd_boolean elf_parse_notes (bfd *abfd, char *buf, size_t size, file_ptr offset, size_t align) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 0836eb36e6d..cbc75cc854f 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2020-12-17 Mihails Strasuns + + * linux-tdep.c (linux_make_mappings_corefile_notes): Start using + elfcore_write_file_note. + 2021-01-26 Shahab Vahedi * arc-tdep.c (arc_add_reggroups): New function. diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c index 5b3b8874d11..e9f8e1b6133 100644 --- a/gdb/linux-tdep.c +++ b/gdb/linux-tdep.c @@ -1591,11 +1591,9 @@ linux_make_mappings_corefile_notes (struct gdbarch *gdbarch, bfd *obfd, obstack_grow (&data_obstack, obstack_base (&filename_obstack), size); - note_data.reset (elfcore_write_note - (obfd, note_data.release (), - note_size, "CORE", NT_FILE, - obstack_base (&data_obstack), - obstack_object_size (&data_obstack))); + note_data.reset (elfcore_write_file_note (obfd, note_data.release (), note_size, + obstack_base (&data_obstack), + obstack_object_size (&data_obstack))); } } -- 2.30.2