From 4d279697afbf8fb295274784103be2b837113d5e Mon Sep 17 00:00:00 2001 From: Romain Naour Date: Sat, 13 Jan 2018 17:05:27 +0100 Subject: [PATCH] package/bash: add /bin/bash to /etc/shells When bash is selected, /bin/bash is not added to /etc/shells (see man shells). So, login tools like dropbear reject the ssh connexions for users using bash as shell in /etc/passwd. buildroot authpriv.warn dropbear[853]: User 'kubu' has invalid shell, rejected Reported-by: Jeremy Rosen Signed-off-by: Romain Naour Cc: "Yann E. MORIN" Acked-by: "Yann E. MORIN" Signed-off-by: Thomas Petazzoni --- package/bash/bash.mk | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/package/bash/bash.mk b/package/bash/bash.mk index 089d062875..03f8f286ed 100644 --- a/package/bash/bash.mk +++ b/package/bash/bash.mk @@ -40,10 +40,14 @@ endif endif # Make /bin/sh -> bash (no other shell, better than busybox shells) +# Add /bin/bash to /etc/shells otherwise some login tools like dropbear +# can reject the user connexion. See man shells. define BASH_INSTALL_TARGET_CMDS $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \ DESTDIR=$(TARGET_DIR) exec_prefix=/ install rm -f $(TARGET_DIR)/bin/bashbug + grep -qsE '^/bin/bash' $(TARGET_DIR)/etc/shells \ + || echo "/bin/bash" >> $(TARGET_DIR)/etc/shells endef $(eval $(autotools-package)) -- 2.30.2