From 4d7b2a8a3b12beac09c5d8f8bcbf43a81296e462 Mon Sep 17 00:00:00 2001 From: Kyrylo Tkachov Date: Fri, 27 Nov 2015 09:52:09 +0000 Subject: [PATCH] [RTL-ifcvt] Reject insns that are multiple_sets * ifcvt.c (insn_valid_noce_process_p): Reject insn if it satisfies multiple_sets. (noce_try_cmove_arith): Add checking asserts that orig_a and orig_b are not modified by the final modified insns in the basic blocks. From-SVN: r231004 --- gcc/ChangeLog | 7 +++++++ gcc/ifcvt.c | 5 +++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 9278a0c7276..4510240eb22 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,10 @@ +2015-11-27 Kyrylo Tkachov + + * ifcvt.c (insn_valid_noce_process_p): Reject insn if it satisfies + multiple_sets. + (noce_try_cmove_arith): Add checking asserts that orig_a and orig_b + are not modified by the final modified insns in the basic blocks. + 2015-11-27 Kyrylo Tkachov PR rtl-optimization/68506 diff --git a/gcc/ifcvt.c b/gcc/ifcvt.c index 8ece8734338..c995b0fe5c4 100644 --- a/gcc/ifcvt.c +++ b/gcc/ifcvt.c @@ -1850,6 +1850,7 @@ insn_valid_noce_process_p (rtx_insn *insn, rtx cc) { if (!insn || !NONJUMP_INSN_P (insn) + || multiple_sets (insn) || (cc && set_of (cc, insn))) return false; @@ -2176,7 +2177,7 @@ noce_try_cmove_arith (struct noce_if_info *if_info) swap insn that sets up A with the one that sets up B. If even that doesn't help, punt. */ - modified_in_a = emit_a != NULL_RTX && modified_in_p (orig_b, emit_a); + gcc_checking_assert (!emit_a || !modified_in_p (orig_b, emit_a)); if (tmp_b && then_bb) { FOR_BB_INSNS (then_bb, tmp_insn) @@ -2192,7 +2193,7 @@ noce_try_cmove_arith (struct noce_if_info *if_info) } if (emit_a || modified_in_a) { - modified_in_b = emit_b != NULL_RTX && modified_in_p (orig_a, emit_b); + gcc_checking_assert (!emit_b || !modified_in_p (orig_a, emit_b)); if (tmp_b && else_bb) { FOR_BB_INSNS (else_bb, tmp_insn) -- 2.30.2