From 4d7be0075acd2083772944209c765a7c332a1727 Mon Sep 17 00:00:00 2001 From: Yao Qi Date: Wed, 24 Jun 2015 14:53:03 +0100 Subject: [PATCH] New proc supports_get_siginfo_type Both siginfo-obj.exp and siginfo-thread.exp have the same code checking the support of geting a type of siginfo for a given arch. This patch is to move these code into a proc supports_get_siginfo_type. gdb/testsuite: 2015-06-24 Yao Qi * lib/gdb.exp (supports_get_siginfo_type): New proc. * gdb.base/siginfo-obj.exp: Invoke supports_get_siginfo_type. * gdb.base/siginfo-thread.exp: Likewise. --- gdb/testsuite/ChangeLog | 6 ++++++ gdb/testsuite/gdb.base/siginfo-obj.exp | 4 +--- gdb/testsuite/gdb.base/siginfo-thread.exp | 4 +--- gdb/testsuite/lib/gdb.exp | 13 +++++++++++++ 4 files changed, 21 insertions(+), 6 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 3c8ecc01a47..c209fe6b4e5 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2015-06-24 Yao Qi + + * lib/gdb.exp (supports_get_siginfo_type): New proc. + * gdb.base/siginfo-obj.exp: Invoke supports_get_siginfo_type. + * gdb.base/siginfo-thread.exp: Likewise. + 2015-06-22 Yao Qi * boards/remote-gdbserver-on-localhost.exp: Add comments. diff --git a/gdb/testsuite/gdb.base/siginfo-obj.exp b/gdb/testsuite/gdb.base/siginfo-obj.exp index 0d1b96dc6fe..578c12e3faf 100644 --- a/gdb/testsuite/gdb.base/siginfo-obj.exp +++ b/gdb/testsuite/gdb.base/siginfo-obj.exp @@ -26,9 +26,7 @@ if [target_info exists gdb,nosignals] { continue } -if { ! [istarget "i?86-*-linux*"] - && ! [istarget "x86_64-*-linux*"] - && ! [istarget "arm*-*-linux*"] } { +if { ![supports_get_siginfo_type] } { verbose "Skipping siginfo-obj.exp because of lack of support." return } diff --git a/gdb/testsuite/gdb.base/siginfo-thread.exp b/gdb/testsuite/gdb.base/siginfo-thread.exp index 638bef3fb8b..a00b5aadeb5 100644 --- a/gdb/testsuite/gdb.base/siginfo-thread.exp +++ b/gdb/testsuite/gdb.base/siginfo-thread.exp @@ -21,9 +21,7 @@ if [target_info exists gdb,nosignals] { continue } -if { ! [istarget "i?86-*-linux*"] - && ! [istarget "x86_64-*-linux*"] - && ! [istarget "arm*-*-linux*"] } { +if { ![supports_get_siginfo_type] } { verbose "Skipping siginfo-thread.exp because of lack of support." return } diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 9edf2dcd0d7..761f7d13c48 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -1996,6 +1996,19 @@ gdb_caching_proc support_complex_tests { return $result } +# Return 1 if GDB can get a type for siginfo from the target, otherwise +# return 0. + +proc supports_get_siginfo_type {} { + if { [istarget "i?86-*-linux*"] + || [istarget "x86_64-*-linux*"] + || [istarget "arm*-*-linux*"] } { + return 1 + } else { + return 0 + } +} + # Return 1 if target hardware or OS supports single stepping to signal # handler, otherwise, return 0. -- 2.30.2