From 4da9288745d8f9c0d6918b685522e89c277020c7 Mon Sep 17 00:00:00 2001 From: Tobias Burnus Date: Wed, 18 Mar 2020 12:07:54 +0100 Subject: [PATCH] libgomp testsuite - disable long double for AMDGCN * testsuite/libgomp.oacc-c++/firstprivate-mappings-1.C: Add #define DO_LONG_DOUBLE; set to 1, except for nvidia + gcn. * libgomp.oacc-c-c++-common/firstprivate-mappings-1.c: Likewise. * g++.dg/goacc/firstprivate-mappings-1.C: Only set DO_LONG_DOUBLE if not defined; update comments. * c-c++-common/goacc/firstprivate-mappings-1.c: Likewise. --- gcc/testsuite/ChangeLog | 56 ++++++++++--------- .../goacc/firstprivate-mappings-1.c | 12 ++-- .../g++.dg/goacc/firstprivate-mappings-1.C | 12 ++-- libgomp/ChangeLog | 6 ++ .../firstprivate-mappings-1.C | 9 +++ .../firstprivate-mappings-1.c | 9 +++ 6 files changed, 63 insertions(+), 41 deletions(-) diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 2c7f3505cb3..0b2e4b813f2 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2020-03-18 Tobias Burnus + + * g++.dg/goacc/firstprivate-mappings-1.C: Only set DO_LONG_DOUBLE if + not defined; update comments. + * c-c++-common/goacc/firstprivate-mappings-1.c: Likewise. + 2020-03-18 Richard Biener PR middle-end/94188 @@ -33,8 +39,8 @@ DEFAULT_CXXFLAGS has a value, even if unset by a higher level. 2020-03-17 Andre Vieira - Mihail Ionescu - Srinath Parvathaneni + Mihail Ionescu + Srinath Parvathaneni * gcc.target/arm/mve/intrinsics/vabavq_s16.c: New test. * gcc.target/arm/mve/intrinsics/vabavq_s32.c: Likewise. @@ -72,8 +78,8 @@ * gcc.target/arm/mve/intrinsics/vshlcq_u8.c: Likewise. 2020-03-17 Andre Vieira - Mihail Ionescu - Srinath Parvathaneni + Mihail Ionescu + Srinath Parvathaneni * gcc.target/arm/mve/intrinsics/vabdq_f16.c: New test. * gcc.target/arm/mve/intrinsics/vabdq_f32.c: Likewise. @@ -222,8 +228,8 @@ * gcc.target/arm/mve/intrinsics/vsubq_f32.c: Likewise. 2020-03-17 Andre Vieira - Mihail Ionescu - Srinath Parvathaneni + Mihail Ionescu + Srinath Parvathaneni * gcc.target/arm/mve/intrinsics/vabdq_s16.c: New test. * gcc.target/arm/mve/intrinsics/vabdq_s32.c: Likewise. @@ -587,8 +593,8 @@ * gcc.target/arm/mve/intrinsics/vsubq_u8.c: Likewise. 2020-03-17 Andre Vieira - Mihail Ionescu - Srinath Parvathaneni + Mihail Ionescu + Srinath Parvathaneni * gcc.target/arm/mve/intrinsics/vaddlvq_p_s32.c: New test. * gcc.target/arm/mve/intrinsics/vaddlvq_p_u32.c: Likewise. @@ -606,8 +612,8 @@ * gcc.target/arm/mve/intrinsics/vshlq_u8.c: Likewise. 2020-03-17 Andre Vieira - Mihail Ionescu - Srinath Parvathaneni + Mihail Ionescu + Srinath Parvathaneni * gcc.target/arm/mve/intrinsics/vcreateq_s16.c: New test. * gcc.target/arm/mve/intrinsics/vcreateq_s32.c: Likewise. @@ -629,8 +635,8 @@ * gcc.target/arm/mve/intrinsics/vshrq_n_u8.c: Likewise. 2020-03-17 Andre Vieira - Mihail Ionescu - Srinath Parvathaneni + Mihail Ionescu + Srinath Parvathaneni * gcc.target/arm/mve/intrinsics/vbrsrq_n_f16.c: New test. * gcc.target/arm/mve/intrinsics/vbrsrq_n_f32.c: Likewise. @@ -644,8 +650,8 @@ * gcc.target/arm/mve/intrinsics/vsubq_n_f32.c: Likewise. 2020-03-17 Andre Vieira - Mihail Ionescu - Srinath Parvathaneni + Mihail Ionescu + Srinath Parvathaneni * gcc.target/arm/mve/intrinsics/vctp16q.c: New test. * gcc.target/arm/mve/intrinsics/vctp32q.c: Likewise. @@ -654,8 +660,8 @@ * gcc.target/arm/mve/intrinsics/vpnot.c: Likewise. 2020-03-17 Andre Vieira - Mihail Ionescu - Srinath Parvathaneni + Mihail Ionescu + Srinath Parvathaneni * gcc.target/arm/mve/intrinsics/vabsq_s16.c: New test. * gcc.target/arm/mve/intrinsics/vabsq_s32.c: Likewise. @@ -738,8 +744,8 @@ * gcc.dg/pr94015.c: New test. 2020-03-17 Andre Vieira - Mihail Ionescu - Srinath Parvathaneni + Mihail Ionescu + Srinath Parvathaneni * gcc.target/arm/mve/intrinsics/vcvtq_s16_f16.c: New test. * gcc.target/arm/mve/intrinsics/vcvtq_s32_f32.c: Likewise. @@ -757,8 +763,8 @@ * gcc.target/arm/mve/intrinsics/vrev64q_u8.c: Likewise. 2020-03-17 Andre Vieira - Mihail Ionescu - Srinath Parvathaneni + Mihail Ionescu + Srinath Parvathaneni * gcc.target/arm/mve/intrinsics/vabsq_f16.c: New test. * gcc.target/arm/mve/intrinsics/vabsq_f32.c: Likewise. @@ -789,8 +795,8 @@ * gcc.target/arm/mve/intrinsics/vrndxq_f32.c: Likewise. 2020-03-16 Andre Vieira - Mihail Ionescu - Srinath Parvathaneni + Mihail Ionescu + Srinath Parvathaneni * gcc.target/arm/mve/intrinsics/vst4q_f16.c: New test. * gcc.target/arm/mve/intrinsics/vst4q_f32.c: Likewise. @@ -866,8 +872,8 @@ 2020-03-16 Andre Vieira - Mihail Ionescu - Srinath Parvathaneni + Mihail Ionescu + Srinath Parvathaneni * gcc.target/arm/mve/intrinsics/mve_vector_float.c: New test. * gcc.target/arm/mve/intrinsics/mve_vector_float1.c: Likewise. @@ -1296,7 +1302,7 @@ 2020-03-04 Martin Sebor PR tree-optimization/93986 - * gcc.dg/pr93986.c: New test. + * gcc.dg/pr93986.c: New test. 2020-03-04 David Malcolm diff --git a/gcc/testsuite/c-c++-common/goacc/firstprivate-mappings-1.c b/gcc/testsuite/c-c++-common/goacc/firstprivate-mappings-1.c index 33576c50eca..7987beaed9a 100644 --- a/gcc/testsuite/c-c++-common/goacc/firstprivate-mappings-1.c +++ b/gcc/testsuite/c-c++-common/goacc/firstprivate-mappings-1.c @@ -2,7 +2,9 @@ /* This file is also sourced from '../../../../libgomp/testsuite/libgomp.oacc-c-c++-common/firstprivate-mappings-1.c' - as an execution test. */ + as an execution test. + + 'long double' tests are compiled/used unless DO_LONG_DOUBLE is set to 0. */ /* See also '../../g++.dg/goacc/firstprivate-mappings-1.C'. */ @@ -24,13 +26,7 @@ # define HAVE_INT128 0 #endif - -/* The one is only relevant for offloading compilation; will always be enabled - when doing tree scanning. */ -#ifdef ACC_DEVICE_TYPE_nvidia -/* PR71064. */ -# define DO_LONG_DOUBLE 0 -#else +#ifndef DO_LONG_DOUBLE # define DO_LONG_DOUBLE 1 #endif diff --git a/gcc/testsuite/g++.dg/goacc/firstprivate-mappings-1.C b/gcc/testsuite/g++.dg/goacc/firstprivate-mappings-1.C index 639bf3f3299..1b1badb1a90 100644 --- a/gcc/testsuite/g++.dg/goacc/firstprivate-mappings-1.C +++ b/gcc/testsuite/g++.dg/goacc/firstprivate-mappings-1.C @@ -2,7 +2,9 @@ /* This file is also sourced from '../../../../libgomp/testsuite/libgomp.oacc-c++/firstprivate-mappings-1.C' - as an execution test. */ + as an execution test. + + 'long double' tests are compiled/used unless DO_LONG_DOUBLE is set to 0. */ /* See also '../../c-c++-common/goacc/firstprivate-mappings-1.c'. */ @@ -21,13 +23,7 @@ # define HAVE_INT128 0 #endif - -/* The one is only relevant for offloading compilation; will always be enabled - when doing tree scanning. */ -#ifdef ACC_DEVICE_TYPE_nvidia -/* PR71064. */ -# define DO_LONG_DOUBLE 0 -#else +#ifndef DO_LONG_DOUBLE # define DO_LONG_DOUBLE 1 #endif diff --git a/libgomp/ChangeLog b/libgomp/ChangeLog index 5882c8a13f3..3dbe94bc982 100644 --- a/libgomp/ChangeLog +++ b/libgomp/ChangeLog @@ -1,3 +1,9 @@ +2020-03-18 Tobias Burnus + + * testsuite/libgomp.oacc-c++/firstprivate-mappings-1.C: Add + #define DO_LONG_DOUBLE; set to 1, except for nvidia + gcn. + * libgomp.oacc-c-c++-common/firstprivate-mappings-1.c: Likewise. + 2020-03-14 Jakub Jelinek PR middle-end/93566 diff --git a/libgomp/testsuite/libgomp.oacc-c++/firstprivate-mappings-1.C b/libgomp/testsuite/libgomp.oacc-c++/firstprivate-mappings-1.C index c8dba9e5d1c..7b3e670073c 100644 --- a/libgomp/testsuite/libgomp.oacc-c++/firstprivate-mappings-1.C +++ b/libgomp/testsuite/libgomp.oacc-c++/firstprivate-mappings-1.C @@ -1,3 +1,12 @@ /* Verify OpenACC 'firstprivate' mappings for C++ reference types. */ +/* PR middle-end/48591 */ +/* PR other/71064 */ +/* Set to 0 for offloading targets not supporting long double. */ +#if defined(ACC_DEVICE_TYPE_nvidia) || defined(ACC_DEVICE_TYPE_gcn) +# define DO_LONG_DOUBLE 0 +#else +# define DO_LONG_DOUBLE 1 +#endif + #include "../../../gcc/testsuite/g++.dg/goacc/firstprivate-mappings-1.C" diff --git a/libgomp/testsuite/libgomp.oacc-c-c++-common/firstprivate-mappings-1.c b/libgomp/testsuite/libgomp.oacc-c-c++-common/firstprivate-mappings-1.c index 4a8b310414c..253f8bf0bd0 100644 --- a/libgomp/testsuite/libgomp.oacc-c-c++-common/firstprivate-mappings-1.c +++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/firstprivate-mappings-1.c @@ -3,4 +3,13 @@ /* { dg-additional-options "-Wno-psabi" } as apparently we're doing funny things with vector arguments. */ +/* PR middle-end/48591 */ +/* PR other/71064 */ +/* Set to 0 for offloading targets not supporting long double. */ +#if defined(ACC_DEVICE_TYPE_nvidia) || defined(ACC_DEVICE_TYPE_gcn) +# define DO_LONG_DOUBLE 0 +#else +# define DO_LONG_DOUBLE 1 +#endif + #include "../../../gcc/testsuite/c-c++-common/goacc/firstprivate-mappings-1.c" -- 2.30.2