From 4e28d4cc5b134a4027b4103ddaf09c19b8e0230b Mon Sep 17 00:00:00 2001 From: Tamar Christina Date: Thu, 19 Sep 2019 13:15:02 +0100 Subject: [PATCH] AArch64: Fix objdump tests The newly added objdump -S tests check for source line mapping of a static variable. But the test doesn't dump any data sections so this should never pass. This changes the test to dump all sections so the source mapping can be found. binutils/ChangeLog: * testsuite/binutils-all/objdump.exp (objdump -S): Update testcases. --- binutils/ChangeLog | 4 ++++ binutils/testsuite/binutils-all/objdump.exp | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/binutils/ChangeLog b/binutils/ChangeLog index 9f6300f17d6..9d1aa848fbf 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,3 +1,7 @@ +2019-09-18 Tamar Christina + + * testsuite/binutils-all/objdump.exp (objump -S): Update testcases. + 2019-09-18 Alan Modra * addr2line.c, * bucomm.c, * coffgrok.c, * dlltool.c, * nm.c, diff --git a/binutils/testsuite/binutils-all/objdump.exp b/binutils/testsuite/binutils-all/objdump.exp index 9630bacb905..58b66d4bb60 100644 --- a/binutils/testsuite/binutils-all/objdump.exp +++ b/binutils/testsuite/binutils-all/objdump.exp @@ -818,7 +818,7 @@ proc test_objdump_S { } { return } - set got [binutils_run $OBJDUMP "$OBJDUMPFLAGS -S tmpdir/testprog"] + set got [binutils_run $OBJDUMP "$OBJDUMPFLAGS -D -S tmpdir/testprog"] set want "static int local = 2" @@ -830,7 +830,7 @@ proc test_objdump_S { } { set test "objdump --source-comment" - set got [binutils_run $OBJDUMP "$OBJDUMPFLAGS --source-comment=// tmpdir/testprog"] + set got [binutils_run $OBJDUMP "$OBJDUMPFLAGS --disassemble-all --source-comment=// tmpdir/testprog"] set want "//static int local = 2" -- 2.30.2