From 4e83a1e776c0acdaca9e69be9576db9efcd5f511 Mon Sep 17 00:00:00 2001 From: Ulrich Weigand Date: Thu, 27 Aug 2015 19:06:03 +0200 Subject: [PATCH] Report UNRESOLVED on failures while detecting Cell/B.E. The gdb.cell testcases use the predicate skip_cell_tests defined in lib/cell.exp to determine whether Cell/B.E. test cases ought to be run. This tests verifies that we have a toolchain that supports generating combined Cell/B.E. binaries, and that the target machine actually is a Cell/B.E. In order to do so, a small test program is built and run (under the debugger). Any failure is taken as a sign that we don't have a Cell/B.E. machine and the tests are to be skipped. This has the unfortunate effect that a serious bug in GDB that causes internal compiler errors even on the trivial test program does not lead to any failures in the testsuite, since now all gdb.cell test are simply skipped. This patch changes skip_cell_tests to at least report UNRESOLVED in cases where execution of the test program fails in unexpected ways. testsuite/ChangeLog: * lib/cell.exp (skip_cell_tests): Report UNRESOLVED on unexpected failures to run the test program under GDB. --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/lib/cell.exp | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 7b271e2b8c0..e5de0a3a412 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2015-08-27 Ulrich Weigand + + * lib/cell.exp (skip_cell_tests): Report UNRESOLVED on unexpected + failures to run the test program under GDB. + 2015-08-26 Luis Machado * gdb.compile/compile-ifunc.exp (with_test_prefix): Force language diff --git a/gdb/testsuite/lib/cell.exp b/gdb/testsuite/lib/cell.exp index f7660a0f1e0..ee7483166ee 100644 --- a/gdb/testsuite/lib/cell.exp +++ b/gdb/testsuite/lib/cell.exp @@ -139,7 +139,7 @@ gdb_caching_proc skip_cell_tests { set result 1 } default { - verbose -log "\n$me Cell/B.E. hardware not detected (default case)" + unresolved "$me: unexpected failure" set result 1 } } -- 2.30.2