From 4ebfc96eba45f869ad109fdb7d1149bb4af3b3a2 Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Wed, 21 May 2014 18:30:43 +0100 Subject: [PATCH] Rename "target child" to "target native". I had been pondering renaming "target child" to something else. "child" is a little lie in case of "attach", and not exactly very clear to users, IMO. By best suggestion is "target native". If I were to explain what "target child" is, I'd just start out with "it's the native target" anyway. I was worrying a little that "native" might be a lie too if some port comes up with a default target that can run but is not really native, but I think that's a very minor issue - we can consider that "native" really means the default built in target that GDB supports, instead of saying that's the target that debugs host native processes, if it turns out necessary. This change doesn't affect users much, because "target child" results in error today: (gdb) target child Use the "run" command to start a child process. Other places "child" is visible: (gdb) help target ... List of target subcommands: target child -- Child process (started by the "run" command) target core -- Use a core file as a target target exec -- Use an executable file as a target ... (gdb) info target Symbols from "/home/pedro/gdb/mygit/build/gdb/gdb". Child process: Using the running image of child Thread 0x7ffff7fc9740 (LWP 4818). While running this, GDB does not access memory from... ... These places will say "native" instead. I think that's a good thing. gdb/ 2014-05-21 Pedro Alves * inf-child.c (inf_child_open): Remove mention of "child". (inf_child_target): Rename target to "native" instead of "child". gdb/testsuite/ 2014-05-21 Pedro Alves * gdb.base/default.exp: Test "target native" instead of "target child". --- gdb/ChangeLog | 5 +++++ gdb/inf-child.c | 8 ++++---- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.base/default.exp | 4 ++-- 4 files changed, 16 insertions(+), 6 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 0291b2c6150..3775095934b 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2014-05-21 Pedro Alves + + * inf-child.c (inf_child_open): Remove mention of "child". + (inf_child_target): Rename target to "native" instead of "child". + 2014-05-21 Andreas Arnez * Makefile.in (SFILES): Delete "regset.c". diff --git a/gdb/inf-child.c b/gdb/inf-child.c index 282467b6b32..8a99adc01c4 100644 --- a/gdb/inf-child.c +++ b/gdb/inf-child.c @@ -112,7 +112,7 @@ inf_child_prepare_to_store (struct target_ops *self, static void inf_child_open (char *arg, int from_tty) { - error (_("Use the \"run\" command to start a child process.")); + error (_("Use the \"run\" command to start a process.")); } static void @@ -406,9 +406,9 @@ inf_child_target (void) { struct target_ops *t = XCNEW (struct target_ops); - t->to_shortname = "child"; - t->to_longname = "Child process"; - t->to_doc = "Child process (started by the \"run\" command)."; + t->to_shortname = "native"; + t->to_longname = "Native process"; + t->to_doc = "Native process (started by the \"run\" command)."; t->to_open = inf_child_open; t->to_post_attach = inf_child_post_attach; t->to_fetch_registers = inf_child_fetch_inferior_registers; diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index c285612c692..790a82a6a03 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2014-05-21 Pedro Alves + + * gdb.base/default.exp: Test "target native" instead of "target + child". + 2014-05-21 Mark Wielaard * gdb.cp/var-tag.exp (do_global_tests): Handle underlying type. diff --git a/gdb/testsuite/gdb.base/default.exp b/gdb/testsuite/gdb.base/default.exp index a39ffcf900e..3636fa3d709 100644 --- a/gdb/testsuite/gdb.base/default.exp +++ b/gdb/testsuite/gdb.base/default.exp @@ -746,8 +746,8 @@ gdb_test "step" "The program is not being run." "step #2" #test symbol-file gdb_test "symbol-file" ".*" "symbol-file" -#test target child -gdb_test "target child" "Use the \"run\" command to start a child process.*|Undefined target command: \"child\". *Try \"help target\".*" "target child" +#test target native +gdb_test "target native" "Use the \"run\" command to start a process.*|Undefined target command: \"child\". *Try \"help target\".*" "target native" #test target core send_gdb "target core\n" -- 2.30.2