From 4ee3237e0b5796d047d0b9f01fbe0277ff14d083 Mon Sep 17 00:00:00 2001 From: Mikael Morin Date: Thu, 18 Aug 2011 23:39:42 +0200 Subject: [PATCH] re PR fortran/50071 (gfortran does not distinguish labels in different type scoping units) 2011-08-18 Mikael Morin PR fortran/50071 * symbol.c (gfc_get_st_label): Use the derived type namespace when we are parsing a derived type definition. 2011-08-18 Mikael Morin PR fortran/50071 * gfortran.dg/duplicate_labels_2.f: New test. From-SVN: r177882 --- gcc/fortran/ChangeLog | 6 +++++ gcc/fortran/symbol.c | 15 +++++++---- gcc/testsuite/ChangeLog | 5 ++++ .../gfortran.dg/duplicate_labels_2.f | 25 +++++++++++++++++++ 4 files changed, 46 insertions(+), 5 deletions(-) create mode 100644 gcc/testsuite/gfortran.dg/duplicate_labels_2.f diff --git a/gcc/fortran/ChangeLog b/gcc/fortran/ChangeLog index fa92219393b..85538ee50f5 100644 --- a/gcc/fortran/ChangeLog +++ b/gcc/fortran/ChangeLog @@ -1,3 +1,9 @@ +2011-08-18 Mikael Morin + + PR fortran/50071 + * symbol.c (gfc_get_st_label): Use the derived type namespace when + we are parsing a derived type definition. + 2011-08-18 Tobias Burnus PR fortran/18918 diff --git a/gcc/fortran/symbol.c b/gcc/fortran/symbol.c index b761cdd47e8..446346029ca 100644 --- a/gcc/fortran/symbol.c +++ b/gcc/fortran/symbol.c @@ -2127,11 +2127,16 @@ gfc_get_st_label (int labelno) gfc_st_label *lp; gfc_namespace *ns; - /* Find the namespace of the scoping unit: - If we're in a BLOCK construct, jump to the parent namespace. */ - ns = gfc_current_ns; - while (ns->proc_name && ns->proc_name->attr.flavor == FL_LABEL) - ns = ns->parent; + if (gfc_current_state () == COMP_DERIVED) + ns = gfc_current_block ()->f2k_derived; + else + { + /* Find the namespace of the scoping unit: + If we're in a BLOCK construct, jump to the parent namespace. */ + ns = gfc_current_ns; + while (ns->proc_name && ns->proc_name->attr.flavor == FL_LABEL) + ns = ns->parent; + } /* First see if the label is already in this namespace. */ lp = ns->st_labels; diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 47379668f81..150c1e55d86 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2011-08-18 Mikael Morin + + PR fortran/50071 + * gfortran.dg/duplicate_labels_2.f: New test. + 2011-08-18 Joseph Myers * gcc.dg/c1x-noreturn-1.c, gcc.dg/c1x-noreturn-2.c, diff --git a/gcc/testsuite/gfortran.dg/duplicate_labels_2.f b/gcc/testsuite/gfortran.dg/duplicate_labels_2.f new file mode 100644 index 00000000000..8a3692dd688 --- /dev/null +++ b/gcc/testsuite/gfortran.dg/duplicate_labels_2.f @@ -0,0 +1,25 @@ +! { dg-do compile } +! +! PR fortran/50071 +! Duplicate statement labels should not be rejected if they appear in +! different scoping units +! +! Contributed by Vittorio Zecca + +c gfortran complains about duplicate statement labels +c this is a legal program because types have their own scoping units +c and you may have same labels in different scoping units, +c as you may have same identifiers inside, like G. + type t1 +1 integer G + end type + type t2 +1 integer G + end type +c this is legal + goto 1 + print *,'bad' +1 continue + print *,'good' + end + -- 2.30.2