From 4f38b48e05f544dd081e9374b4611496febbdd67 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Marek=20Ol=C5=A1=C3=A1k?= Date: Wed, 21 Jun 2017 22:32:20 +0200 Subject: [PATCH] mesa/glthread: decrease the batch size for better perf scaling This is the key to better performance. Reviewed-by: Timothy Arceri --- src/mesa/main/glthread.h | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/glthread.h b/src/mesa/main/glthread.h index 36692fe5704..dd65931478e 100644 --- a/src/mesa/main/glthread.h +++ b/src/mesa/main/glthread.h @@ -26,8 +26,16 @@ #include "main/mtypes.h" -/* Command size is a number of bytes stored in a short. */ -#define MARSHAL_MAX_CMD_SIZE 65535 +/* The size of one batch and the maximum size of one call. + * + * This should be as low as possible, so that: + * - multiple synchronizations within a frame don't slow us down much + * - a smaller number of calls per frame can still get decent parallelism + * - the memory footprint of the queue is low, and with that comes a lower + * chance of experiencing CPU cache thrashing + * but it should be high enough so that u_queue overhead remains negligible. + */ +#define MARSHAL_MAX_CMD_SIZE (8 * 1024) /* The number of batch slots in memory. * @@ -35,7 +43,7 @@ * waiting batches. There must be at least 1 slot for a waiting batch, * so the minimum number of batches is 3. */ -#define MARSHAL_MAX_BATCHES 4 +#define MARSHAL_MAX_BATCHES 8 #include #include -- 2.30.2