From 509fdd5a8720250b8e0ddb5691ec94352c85e970 Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Thu, 20 Apr 2023 07:01:22 +0930 Subject: [PATCH] sh4-linux segfaults running ld testsuite Segmentation fault FAIL: pr22269-1 (static pie undefined weak) and others running "visibility (hidden undef)" tests No code has any right to access bfd_link_hash_entry u.def without first checking the type, and SYMBOL_REFERENCES_LOCAL isn't sufficient. * elf32-sh.c (sh_elf_finish_dynamic_symbol): Don't use relative relocs in GOT unless symbol is defined. --- bfd/elf32-sh.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/bfd/elf32-sh.c b/bfd/elf32-sh.c index fdcc5870890..499233d1355 100644 --- a/bfd/elf32-sh.c +++ b/bfd/elf32-sh.c @@ -6174,6 +6174,8 @@ sh_elf_finish_dynamic_symbol (bfd *output_bfd, struct bfd_link_info *info, The entry in the global offset table will already have been initialized in the relocate_section function. */ if (bfd_link_pic (info) + && (h->root.type == bfd_link_hash_defined + || h->root.type == bfd_link_hash_defweak) && SYMBOL_REFERENCES_LOCAL (info, h)) { if (htab->fdpic_p) -- 2.30.2