From 50a8713d4f90a6c70a23f9f5871420371df283a7 Mon Sep 17 00:00:00 2001 From: Eric Anholt Date: Thu, 2 Aug 2018 11:12:37 -0700 Subject: [PATCH] v3d: Avoid spilling that breaks the r5 usage after a ldvary. Fixes bad rendering when forcing 2 spills in glxgears. Cc: "18.2" --- src/broadcom/compiler/vir_register_allocate.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/broadcom/compiler/vir_register_allocate.c b/src/broadcom/compiler/vir_register_allocate.c index bc34f68e59a..accc07a3a33 100644 --- a/src/broadcom/compiler/vir_register_allocate.c +++ b/src/broadcom/compiler/vir_register_allocate.c @@ -94,6 +94,15 @@ v3d_choose_spill_node(struct v3d_compile *c, struct ra_graph *g, } } + /* Refuse to spill a ldvary's dst, because that means + * that ldvary's r5 would end up being used across a + * thrsw. + */ + if (inst->qpu.sig.ldvary) { + assert(inst->dst.file == QFILE_TEMP); + BITSET_CLEAR(c->spillable, inst->dst.index); + } + if (inst->is_last_thrsw) started_last_seg = true; -- 2.30.2