From 51415b9f309443261016ad1b63b9e350bbe3903d Mon Sep 17 00:00:00 2001 From: Andrew Burgess Date: Tue, 24 May 2016 16:53:58 +0100 Subject: [PATCH] gdb: Forward VALUE_LVAL when avoiding side effects for STRUCTOP_STRUCT When evaluating an expression with EVAL_AVOID_SIDE_EFFECTS if the value we return is forced to be of type not_lval then GDB will be unable to take the address of the returned value. Instead, we should properly initialise the LVAL of the returned value. This commit builds on two previous commits 2520f728b710 (Forward VALUE_LVAL when avoiding side effects for STRUCTOP_STRUCT) and ac775bf4d35b (gdb: Forward VALUE_LVAL when avoiding side effects for STRUCTOP_PTR), which in turn build on ac1ca910d74d (Fixes for PR exp/15364). This commit is currently untested due to my lack of access to an OpenCL compiler, however, if follows the same pattern as the first two commits mentioned above and so I believe that it is correct. gdb/ChangeLog: * opencl-lang.c (evaluate_subexp_opencl): If EVAL_AVOID_SIDE_EFFECTS mode, forward the VALUE_LVAL attribute to the returned value in the STRUCTOP_STRUCT case. --- gdb/ChangeLog | 6 ++++++ gdb/opencl-lang.c | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 6884c2db3b8..14da5647739 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2016-05-27 Andrew Burgess + + * opencl-lang.c (evaluate_subexp_opencl): If + EVAL_AVOID_SIDE_EFFECTS mode, forward the VALUE_LVAL attribute to + the returned value in the STRUCTOP_STRUCT case. + 2016-05-27 Andrew Burgess * eval.c (evaluate_subexp_standard): If EVAL_AVOID_SIDE_EFFECTS diff --git a/gdb/opencl-lang.c b/gdb/opencl-lang.c index 77997357904..767d3bc73e0 100644 --- a/gdb/opencl-lang.c +++ b/gdb/opencl-lang.c @@ -984,7 +984,7 @@ Cannot perform conditional operation on vectors with different sizes")); "structure"); if (noside == EVAL_AVOID_SIDE_EFFECTS) - v = value_zero (value_type (v), not_lval); + v = value_zero (value_type (v), VALUE_LVAL (v)); return v; } } -- 2.30.2