From 52271982a769099f6f7f8db8eee700fe09490dbe Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Tue, 24 Sep 2002 01:46:42 +0000 Subject: [PATCH] * config/tc-i386.c (process_operands): Warn about "lea" segment overrides. --- gas/ChangeLog | 5 +++++ gas/config/tc-i386.c | 19 ++++++++++--------- 2 files changed, 15 insertions(+), 9 deletions(-) diff --git a/gas/ChangeLog b/gas/ChangeLog index 97dd2cde9d3..eaef1392d35 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,8 @@ +2002-09-24 Alan Modra + + * config/tc-i386.c (process_operands): Warn about "lea" segment + overrides. + 2002-09-22 Mark Elbrecht * write.c: Delete set_segment_vma and prototype. Update all callers. diff --git a/gas/config/tc-i386.c b/gas/config/tc-i386.c index c46b65b5a9a..4db65b8349a 100644 --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -2604,9 +2604,8 @@ process_operands () else if (i.tm.opcode_modifier & Modrm) { /* The opcode is completed (modulo i.tm.extension_opcode which - must be put into the modrm byte). - Now, we make the modrm & index base bytes based on all the - info we've collected. */ + must be put into the modrm byte). Now, we make the modrm and + index base bytes based on all the info we've collected. */ default_seg = build_modrm_byte (); } @@ -2633,12 +2632,14 @@ process_operands () default_seg = &ds; } - /* If a segment was explicitly specified, - and the specified segment is not the default, - use an opcode prefix to select it. - If we never figured out what the default segment is, - then default_seg will be zero at this point, - and the specified segment prefix will always be used. */ + if (i.tm.base_opcode == 0x8d /* lea */ && i.seg[0] && !quiet_warnings) + as_warn (_("segment override on `lea' is ineffectual")); + + /* If a segment was explicitly specified, and the specified segment + is not the default, use an opcode prefix to select it. If we + never figured out what the default segment is, then default_seg + will be zero at this point, and the specified segment prefix will + always be used. */ if ((i.seg[0]) && (i.seg[0] != default_seg)) { if (!add_prefix (i.seg[0]->seg_prefix)) -- 2.30.2