From 524a555ad1f81f132aaed0badaece1b8b95c8ae7 Mon Sep 17 00:00:00 2001 From: Thomas Petazzoni Date: Sun, 29 Mar 2015 19:33:16 +0200 Subject: [PATCH] pkg-generic: fix the logic showing the "Downloading" message Even though the .stamp_downloaded target is executed for each package being built, the pkg-generic infrastructure tries to not display the "Downloading" message when there is in fact nothing to download. Unfortunately, the logic was incorrect for the patch download: it forgot the fact that _PATCH can contain either file names (in which case we assume the patch should be downloaded from _SITE), or full URLs. The latter case was not properly handled, as we were checking if $(DL_DIR)/ existed, while we should be testing if $(DL_DIR)/`basename ` exists. This patch fixes that, which makes sure the "Downloading" message is displayed only when necessary. Signed-off-by: Thomas Petazzoni Reviewed-by: Romain Naour Reviewed-by: Arnout Vandecappelle (Essensium/Mind) Acked-by: "Yann E. MORIN" --- package/pkg-generic.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk index c1b379bf87..b44d476379 100644 --- a/package/pkg-generic.mk +++ b/package/pkg-generic.mk @@ -77,7 +77,7 @@ ifeq ($(DL_MODE),DOWNLOAD) $(call MESSAGE,"Downloading") ; \ else \ for p in $($(PKG)_PATCH) ; do \ - if test ! -e $(DL_DIR)/$$p ; then \ + if test ! -e $(DL_DIR)/`basename $$p` ; then \ $(call MESSAGE,"Downloading") ; \ break ; \ fi ; \ -- 2.30.2