From 531336e3a0b79ed60cfc36ad2d6579b6a71175da Mon Sep 17 00:00:00 2001 From: Nick Clifton Date: Fri, 2 Dec 2016 16:41:14 +0000 Subject: [PATCH] Fix seg-fault in the linker when examining a corrupt binary. PR ld/20909 * aoutx.h (aout_link_add_symbols): Fix off-by-one error in check for an illegal string offset. --- bfd/ChangeLog | 6 ++++++ bfd/aoutx.h | 3 +-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index d061e66a260..c8085e7b42c 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,9 @@ +2016-12-02 Nick Clifton + + PR ld/20909 + * aoutx.h (aout_link_add_symbols): Fix off-by-one error in check + for an illegal string offset. + 2016-12-02 Gary Benson * elf.c (_bfd_elf_make_section_from_shdr): Pass offset to diff --git a/bfd/aoutx.h b/bfd/aoutx.h index 4308679207d..b9ac2b7f9e5 100644 --- a/bfd/aoutx.h +++ b/bfd/aoutx.h @@ -3031,10 +3031,9 @@ aout_link_add_symbols (bfd *abfd, struct bfd_link_info *info) continue; /* PR 19629: Corrupt binaries can contain illegal string offsets. */ - if (GET_WORD (abfd, p->e_strx) > obj_aout_external_string_size (abfd)) + if (GET_WORD (abfd, p->e_strx) >= obj_aout_external_string_size (abfd)) return FALSE; name = strings + GET_WORD (abfd, p->e_strx); - value = GET_WORD (abfd, p->e_value); flags = BSF_GLOBAL; string = NULL; -- 2.30.2