From 538bca78e267b1c8cce41d5b4623fafd1e253d82 Mon Sep 17 00:00:00 2001 From: Eric Anholt Date: Tue, 6 Nov 2018 09:39:40 -0800 Subject: [PATCH] v3d: Don't try to set PF flags on a LDTMU operation We need an ALU op in order to set PF. Fixes a recent assertion failure in dEQP-GLES3.functional.ubo.single_basic_type.shared.bool_vertex --- src/broadcom/compiler/vir.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/broadcom/compiler/vir.c b/src/broadcom/compiler/vir.c index 3f5a28d1be0..9a671c6c97f 100644 --- a/src/broadcom/compiler/vir.c +++ b/src/broadcom/compiler/vir.c @@ -1006,6 +1006,12 @@ vir_can_set_flags(struct v3d_compile *c, struct qinst *inst) return false; } + if (inst->qpu.type != V3D_QPU_INSTR_TYPE_ALU || + (inst->qpu.alu.add.op == V3D_QPU_A_NOP && + inst->qpu.alu.mul.op == V3D_QPU_M_NOP)) { + return false; + } + return true; } -- 2.30.2