From 53dd3bccac6f7f5d4a57875ca5ee2acfe2b2056f Mon Sep 17 00:00:00 2001 From: Luo Xiong Hu Date: Fri, 15 Nov 2019 08:17:31 +0000 Subject: [PATCH] Fix comments typo gcc/ChangeLog: 2019-11-15 Luo Xiong Hu * ipa-comdats.c: Fix comments typo. * ipa-profile.c: Fix comments typo. * tree-profile.c (gimple_gen_ic_profiler): Use the new variable __gcov_indirect_call.counters and __gcov_indirect_call.callee. (gimple_gen_ic_func_profiler): Likewise. (pass_ipa_tree_profile::gate): Fix comments typo. From-SVN: r278278 --- gcc/ChangeLog | 9 +++++++++ gcc/ipa-comdats.c | 2 +- gcc/ipa-profile.c | 2 +- gcc/tree-profile.c | 12 ++++++------ 4 files changed, 17 insertions(+), 8 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index cd8e656540b..e5d9e38196c 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,12 @@ +2019-11-15 Luo Xiong Hu + + * ipa-comdats.c: Fix comments typo. + * ipa-profile.c: Fix comments typo. + * tree-profile.c (gimple_gen_ic_profiler): Use the new variable + __gcov_indirect_call.counters and __gcov_indirect_call.callee. + (gimple_gen_ic_func_profiler): Likewise. + (pass_ipa_tree_profile::gate): Fix comments typo. + 2019-11-15 Xiong Hu Luo * ipa-inline.c (inline_small_functions): Update iterator of next. diff --git a/gcc/ipa-comdats.c b/gcc/ipa-comdats.c index b496497ff66..0672d6d6575 100644 --- a/gcc/ipa-comdats.c +++ b/gcc/ipa-comdats.c @@ -18,7 +18,7 @@ along with GCC; see the file COPYING3. If not see . */ /* This is very simple pass that looks for static symbols that are used - exlusively by symbol within one comdat group. In this case it makes + exclusively by symbol within one comdat group. In this case it makes sense to bring the symbol itself into the group to avoid dead code that would arrise when the comdat group from current unit is replaced by a different copy. Consider for example: diff --git a/gcc/ipa-profile.c b/gcc/ipa-profile.c index 61fd5e86681..4b28b94aaad 100644 --- a/gcc/ipa-profile.c +++ b/gcc/ipa-profile.c @@ -563,7 +563,7 @@ ipa_profile (void) histogram.release (); histogram_pool.release (); - /* Produce speculative calls: we saved common traget from porfiling into + /* Produce speculative calls: we saved common target from porfiling into e->common_target_id. Now, at link time, we can look up corresponding function node and produce speculative call. */ diff --git a/gcc/tree-profile.c b/gcc/tree-profile.c index 6a4e62f5bae..b4435b9b2a8 100644 --- a/gcc/tree-profile.c +++ b/gcc/tree-profile.c @@ -73,8 +73,8 @@ static GTY(()) tree ic_tuple_callee_field; /* Do initialization work for the edge profiler. */ /* Add code: - __thread gcov* __gcov_indirect_call_counters; // pointer to actual counter - __thread void* __gcov_indirect_call_callee; // actual callee address + __thread gcov* __gcov_indirect_call.counters; // pointer to actual counter + __thread void* __gcov_indirect_call.callee; // actual callee address __thread int __gcov_function_counter; // time profiler function counter */ static void @@ -381,7 +381,7 @@ gimple_gen_ic_profiler (histogram_value value, unsigned tag) f_1 = foo; __gcov_indirect_call.counters = &__gcov4.main[0]; PROF_9 = f_1; - __gcov_indirect_call_callee = PROF_9; + __gcov_indirect_call.callee = PROF_9; _4 = f_1 (); */ @@ -444,11 +444,11 @@ gimple_gen_ic_func_profiler (void) /* Insert code: - if (__gcov_indirect_call_callee != NULL) + if (__gcov_indirect_call.callee != NULL) __gcov_indirect_call_profiler_v3 (profile_id, ¤t_function_decl); The function __gcov_indirect_call_profiler_v3 is responsible for - resetting __gcov_indirect_call_callee to NULL. */ + resetting __gcov_indirect_call.callee to NULL. */ gimple_stmt_iterator gsi = gsi_start_bb (cond_bb); void0 = build_int_cst (ptr_type_node, 0); @@ -890,7 +890,7 @@ pass_ipa_tree_profile::gate (function *) { /* When profile instrumentation, use or test coverage shall be performed. But for AutoFDO, this there is no instrumentation, thus this pass is - diabled. */ + disabled. */ return (!in_lto_p && !flag_auto_profile && (flag_branch_probabilities || flag_test_coverage || profile_arc_flag)); -- 2.30.2