From 54a48984b30daf243613f58b2a982e7b44471ead Mon Sep 17 00:00:00 2001 From: Kenneth Graunke Date: Thu, 17 Apr 2014 18:32:52 -0700 Subject: [PATCH] i965/fs: Port untyped surface read support to Broadwell. v2: Drop unused num_components variable; fix SIMD Mode comment (caught by Eric Anholt). Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=77221 Signed-off-by: Kenneth Graunke Reviewed-by: Eric Anholt --- src/mesa/drivers/dri/i965/brw_fs.h | 3 ++ .../drivers/dri/i965/gen8_fs_generator.cpp | 28 ++++++++++++++++++- 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.h b/src/mesa/drivers/dri/i965/brw_fs.h index 03b2e6a7078..6405dbc1126 100644 --- a/src/mesa/drivers/dri/i965/brw_fs.h +++ b/src/mesa/drivers/dri/i965/brw_fs.h @@ -750,6 +750,9 @@ private: void generate_unpack_half_2x16_split(fs_inst *inst, struct brw_reg dst, struct brw_reg src); + void generate_untyped_surface_read(fs_inst *inst, + struct brw_reg dst, + struct brw_reg surf_index); void generate_discard_jump(fs_inst *ir); void patch_discard_jumps_to_fb_writes(); diff --git a/src/mesa/drivers/dri/i965/gen8_fs_generator.cpp b/src/mesa/drivers/dri/i965/gen8_fs_generator.cpp index 856a23e4827..454b8c85765 100644 --- a/src/mesa/drivers/dri/i965/gen8_fs_generator.cpp +++ b/src/mesa/drivers/dri/i965/gen8_fs_generator.cpp @@ -820,6 +820,32 @@ gen8_fs_generator::generate_unpack_half_2x16_split(fs_inst *inst, MOV(dst, src_hf); } +void +gen8_fs_generator::generate_untyped_surface_read(fs_inst *ir, + struct brw_reg dst, + struct brw_reg surf_index) +{ + assert(surf_index.file == BRW_IMMEDIATE_VALUE && + surf_index.type == BRW_REGISTER_TYPE_UD); + + unsigned msg_control = 0xe | /* Enable only the R channel */ + ((dispatch_width == 16 ? 1 : 2) << 4); /* SIMD Mode */ + + gen8_instruction *inst = next_inst(BRW_OPCODE_SEND); + gen8_set_dst(brw, inst, retype(dst, BRW_REGISTER_TYPE_UD)); + gen8_set_src0(brw, inst, brw_message_reg(ir->base_mrf)); + gen8_set_dp_message(brw, inst, HSW_SFID_DATAPORT_DATA_CACHE_1, + surf_index.dw1.ud, + HSW_DATAPORT_DC_PORT1_UNTYPED_SURFACE_READ, + msg_control, + ir->mlen, + dispatch_width / 8, + ir->header_present, + false); + + brw_mark_surface_used(&c->prog_data.base, surf_index.dw1.ud); +} + void gen8_fs_generator::generate_code(exec_list *instructions) { @@ -1193,7 +1219,7 @@ gen8_fs_generator::generate_code(exec_list *instructions) break; case SHADER_OPCODE_UNTYPED_SURFACE_READ: - assert(!"XXX: Missing Gen8 scalar support for untyped surface reads"); + generate_untyped_surface_read(ir, dst, src[0]); break; case FS_OPCODE_SET_SIMD4X2_OFFSET: -- 2.30.2