From 552a161c8d9305aa1b6017de5bd5d9a4da55ea02 Mon Sep 17 00:00:00 2001 From: Tom de Vries Date: Fri, 15 Apr 2022 16:53:08 +0200 Subject: [PATCH] [gdb/testsuite] Fix gdb.go/methods.exp with check-readmore When running test-case gdb.go/methods.exp with make check we have: ... (gdb) break main.T.Foo^M Function "main.T.Foo" not defined.^M Make breakpoint pending on future shared library load? (y or [n]) n^M (gdb) XFAIL: gdb.go/methods.exp: gdb_breakpoint: set breakpoint at main.T.Foo ... but with make check-readmore the XFAIL fails to trigger: ... (gdb) break main.T.Foo^M Function "main.T.Foo" not defined.^M Make breakpoint pending on future shared library load? (y or [n]) n^M (gdb) FAIL: gdb.go/methods.exp: gdb_breakpoint: set breakpoint at main.T.Foo ... This happens because this gdb_test_multiple "maintenance print symbols" regexp: ... -re "\r\n$gdb_prompt $" { ... matches the entire command output. Fix this by adding the missing ^ at the regexp start. Tested on x86_64-linux. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29064 --- gdb/testsuite/gdb.go/methods.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.go/methods.exp b/gdb/testsuite/gdb.go/methods.exp index aabf1fa5e09..d50fbde122c 100644 --- a/gdb/testsuite/gdb.go/methods.exp +++ b/gdb/testsuite/gdb.go/methods.exp @@ -49,7 +49,7 @@ gdb_test_multiple "maintenance print symbols" "" { -re "^\r\n void main.T.Bar\[^\r\n\]*(?=\r\n)" { exp_continue } - -re "\r\n$gdb_prompt $" { + -re "^\r\n$gdb_prompt $" { pass $gdb_test_name } -re "\r\n\[^\r\n\]*(?=\r\n)" { -- 2.30.2