From 5555c86d3e85e85d76555acdb955aba062beb02f Mon Sep 17 00:00:00 2001 From: Tom de Vries Date: Wed, 5 Aug 2020 12:31:58 +0200 Subject: [PATCH] [gdb] Fix prop->const_val uses in gdbtypes.c After commit 66d6346b25 "gdb: remove TYPE_DYN_PROP_ADDR", I run into: ... FAIL: gdb.fortran/class-allocatable-array.exp: print this%_data%b ... (and 185 more FAILs, all for fortran test-cases). The commit replaces "!x" by "x != 0". Fix this by using "x == 0" instead. Build and tested on x86_64-linux. gdb/ChangeLog: 2020-08-05 Tom de Vries * gdbtypes.c (type_not_allocated, type_not_associated): Use "prop->const_val () == 0" instead of "prop->const_val () != 0". --- gdb/ChangeLog | 5 +++++ gdb/gdbtypes.c | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 2cd89b73b7d..066512703ac 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2020-08-05 Tom de Vries + + * gdbtypes.c (type_not_allocated, type_not_associated): Use + "prop->const_val () == 0" instead of "prop->const_val () != 0". + 2020-08-04 Simon Marchi * frame.h (frame_id_p): Return bool. diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c index 0cd4b194d98..da1c58c65c1 100644 --- a/gdb/gdbtypes.c +++ b/gdb/gdbtypes.c @@ -4134,7 +4134,7 @@ type_not_allocated (const struct type *type) struct dynamic_prop *prop = TYPE_ALLOCATED_PROP (type); return (prop != nullptr && prop->kind () == PROP_CONST - && prop->const_val () != 0); + && prop->const_val () == 0); } /* Associated status of type TYPE. Return zero if type TYPE is associated. @@ -4146,7 +4146,7 @@ type_not_associated (const struct type *type) struct dynamic_prop *prop = TYPE_ASSOCIATED_PROP (type); return (prop != nullptr && prop->kind () == PROP_CONST - && prop->const_val () != 0); + && prop->const_val () == 0); } /* rank_one_type helper for when PARM's type code is TYPE_CODE_PTR. */ -- 2.30.2