From 55dabf65f039c3a5635f01dccb9e4de767f89323 Mon Sep 17 00:00:00 2001 From: Ramana Radhakrishnan Date: Thu, 15 Jun 2017 14:17:04 +0000 Subject: [PATCH] Update comment about is_leaf crtl->is_leaf has a comment above it referring to "Local Register Allocation". However this is set by IRA and not LRA since the meaning of Local Register Allocator in GCC has changed quite drastically since 1999 when this comment was introduced above the variable current_function_is_leaf. From memory gcc in those days had "local" and "global" register allocation - however all of this has changed quite a bit drastically since. This patch merely updates the comment as I did some head scratching this morning about how this could be set before Local Register Allocator especially given the comment in ira.c as below. /* Determine if the current function is a leaf before running IRA since this can impact optimizations done by the prologue and epilogue thus changing register elimination offsets. */ crtl->is_leaf = leaf_function_p (); From-SVN: r249223 --- gcc/ChangeLog | 5 +++++ gcc/emit-rtl.h | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 3f2f34417c6..b8c2f055b47 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2017-06-15 Ramana Radhakrishnan + + * emit-rtl.h (is_leaf): Update comment about local + register allocator. + 2017-06-15 Jozef Lawrynowicz PR target/78818 diff --git a/gcc/emit-rtl.h b/gcc/emit-rtl.h index da60a2d808c..b455b4c00fb 100644 --- a/gcc/emit-rtl.h +++ b/gcc/emit-rtl.h @@ -267,7 +267,7 @@ struct GTY(()) rtl_data { /* Nonzero if function being compiled doesn't contain any calls (ignoring the prologue and epilogue). This is set prior to - local register allocation and is valid for the remaining + register allocation in IRA and is valid for the remaining compiler passes. */ bool is_leaf; -- 2.30.2