From 5603406bd1289d794a336a79da4599e48fd27b2b Mon Sep 17 00:00:00 2001 From: "Arnout Vandecappelle (Essensium/Mind)" Date: Thu, 1 Aug 2019 01:02:20 +0200 Subject: [PATCH] utils/checkpackagelib: CommentsMenusPackagesOrder: only apply to top-level The CommentsMenusPackagesOrder test is broken in various ways for files other than package/Config.in and package/Config.in.host. Therefore, the script gives bogus errors for various other Config.in files. However, we don't really want to check those other files. Indeed, many of them have a non-alphabetical ordering for good reasons. Therefore, skip the check for files other than package/Config.in and package/Config.in.host. Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/251214899 Signed-off-by: Arnout Vandecappelle (Essensium/Mind) Cc: Jerzy Grzegorek Cc: Yann E. MORIN Acked-by: Yann E. MORIN --- utils/checkpackagelib/lib_config.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/utils/checkpackagelib/lib_config.py b/utils/checkpackagelib/lib_config.py index f0edb9993d..7d7567ac67 100644 --- a/utils/checkpackagelib/lib_config.py +++ b/utils/checkpackagelib/lib_config.py @@ -72,6 +72,11 @@ class CommentsMenusPackagesOrder(_CheckFunction): return len(self.state.split('-')) - 1 def check_line(self, lineno, text): + # We only want to force sorting for the top-level menus + if self.filename not in ["package/Config.in", + "package/Config.in.host"]: + return + if text.startswith("comment") or text.startswith("if") or \ text.startswith("menu"): -- 2.30.2