From 56e6461019e051153e00c7a069fd373fddc24e02 Mon Sep 17 00:00:00 2001 From: Doug Evans Date: Mon, 3 Dec 2012 22:31:03 +0000 Subject: [PATCH] * dwarf2read.c (struct dwarf2_per_objfile): Clarify comment. (dw2_find_symbol_file): Delete unused local file_data. --- gdb/ChangeLog | 5 +++++ gdb/dwarf2read.c | 10 ++++++---- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 5e2a263a86e..ae82862f511 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2012-12-03 Doug Evans + + * dwarf2read.c (struct dwarf2_per_objfile): Clarify comment. + (dw2_find_symbol_file): Delete unused local file_data. + 2012-12-03 Tom Tromey * ada-exp.y (write_object_renaming, write_var_or_type) diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index f4bd7a97903..cd81eed0891 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -257,9 +257,12 @@ struct dwarf2_per_objfile struct mapped_index *index_table; /* When using index_table, this keeps track of all quick_file_names entries. - TUs can share line table entries with CUs or other TUs, and there can be - a lot more TUs than unique line tables, so we maintain a separate table - of all line table entries to support the sharing. */ + TUs typically share line table entries with a CU, so we maintain a + separate table of all line table entries to support the sharing. + Note that while there can be way more TUs than CUs, we've already + sorted all the TUs into "type unit groups", grouped by their + DW_AT_stmt_list value. Therefore the only sharing done here is with a + CU and its associated TU group if there is one. */ htab_t quick_file_names_table; /* Set during partial symbol reading, to prevent queueing of full @@ -3385,7 +3388,6 @@ dw2_find_symbol_file (struct objfile *objfile, const char *name) { struct dwarf2_per_cu_data *per_cu; offset_type *vec; - struct quick_file_names *file_data; const char *filename; dw2_setup (objfile); -- 2.30.2