From 574c59d4f935cccfa18f7054c660200f8be791ad Mon Sep 17 00:00:00 2001 From: =?utf8?q?Nicolai=20H=C3=A4hnle?= Date: Sun, 22 Oct 2017 17:38:30 +0200 Subject: [PATCH] u_queue: add util_queue_fence_reset MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Reviewed-by: Marek Olšák --- src/util/u_queue.c | 4 +--- src/util/u_queue.h | 13 +++++++++++++ 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/src/util/u_queue.c b/src/util/u_queue.c index 33436e0749a..2272006042f 100644 --- a/src/util/u_queue.c +++ b/src/util/u_queue.c @@ -328,8 +328,6 @@ util_queue_add_job(struct util_queue *queue, { struct util_queue_job *ptr; - assert(fence->signalled); - mtx_lock(&queue->lock); if (queue->kill_threads) { mtx_unlock(&queue->lock); @@ -339,7 +337,7 @@ util_queue_add_job(struct util_queue *queue, return; } - fence->signalled = false; + util_queue_fence_reset(fence); assert(queue->num_queued >= 0 && queue->num_queued <= queue->max_jobs); diff --git a/src/util/u_queue.h b/src/util/u_queue.h index 5a546e53fdc..a3e12260e30 100644 --- a/src/util/u_queue.h +++ b/src/util/u_queue.h @@ -59,6 +59,19 @@ void util_queue_fence_destroy(struct util_queue_fence *fence); void util_queue_fence_wait(struct util_queue_fence *fence); void util_queue_fence_signal(struct util_queue_fence *fence); +/** + * Move \p fence back into unsignalled state. + * + * \warning The caller must ensure that no other thread may currently be + * waiting (or about to wait) on the fence. + */ +static inline void +util_queue_fence_reset(struct util_queue_fence *fence) +{ + assert(fence->signalled); + fence->signalled = 0; +} + static inline bool util_queue_fence_is_signalled(struct util_queue_fence *fence) { -- 2.30.2