From 57667bad9f6e6920dfbe69b2afc9caaace58bcbe Mon Sep 17 00:00:00 2001 From: Andrea Mondelli Date: Tue, 23 Apr 2019 13:36:19 -0400 Subject: [PATCH] cpu,mem: missing override specifier Change-Id: I731d3ef021596450ac307461f215760a148bb28a Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/18348 Reviewed-by: Jason Lowe-Power Maintainer: Jason Lowe-Power Tested-by: kokoro --- src/cpu/simple_thread.hh | 16 ++++++++++------ src/mem/cache/mshr.hh | 4 ++-- src/mem/cache/write_queue_entry.hh | 4 ++-- 3 files changed, 14 insertions(+), 10 deletions(-) diff --git a/src/cpu/simple_thread.hh b/src/cpu/simple_thread.hh index 46f142f6f..0d415dc16 100644 --- a/src/cpu/simple_thread.hh +++ b/src/cpu/simple_thread.hh @@ -213,26 +213,30 @@ class SimpleThread : public ThreadState, public ThreadContext System *getSystemPtr() override { return system; } TheISA::Kernel::Statistics * - getKernelStats() + getKernelStats() override { return ThreadState::getKernelStats(); } - PortProxy &getPhysProxy() { return ThreadState::getPhysProxy(); } + PortProxy &getPhysProxy() override { return ThreadState::getPhysProxy(); } FSTranslatingPortProxy & - getVirtProxy() + getVirtProxy() override { return ThreadState::getVirtProxy(); } - void initMemProxies(ThreadContext *tc) { ThreadState::initMemProxies(tc); } + void initMemProxies(ThreadContext *tc) override + { + ThreadState::initMemProxies(tc); + } + SETranslatingPortProxy & - getMemProxy() + getMemProxy() override { return ThreadState::getMemProxy(); } - Process *getProcessPtr() { return ThreadState::getProcessPtr(); } + Process *getProcessPtr() override { return ThreadState::getProcessPtr(); } void setProcessPtr(Process *p) override { ThreadState::setProcessPtr(p); } Status status() const override { return _status; } diff --git a/src/mem/cache/mshr.hh b/src/mem/cache/mshr.hh index 4b054894d..3e7b79ea0 100644 --- a/src/mem/cache/mshr.hh +++ b/src/mem/cache/mshr.hh @@ -352,7 +352,7 @@ class MSHR : public QueueEntry, public Printable assert(inService); return postDowngrade; } - bool sendPacket(BaseCache &cache); + bool sendPacket(BaseCache &cache) override; bool allocOnFill() const { return targets.allocOnFill; @@ -523,7 +523,7 @@ class MSHR : public QueueEntry, public Printable */ void print(std::ostream &os, int verbosity = 0, - const std::string &prefix = "") const; + const std::string &prefix = "") const override; /** * A no-args wrapper of print(std::ostream...) meant to be * invoked from DPRINTFs avoiding string overheads in fast mode diff --git a/src/mem/cache/write_queue_entry.hh b/src/mem/cache/write_queue_entry.hh index 9aaac493c..907ef4775 100644 --- a/src/mem/cache/write_queue_entry.hh +++ b/src/mem/cache/write_queue_entry.hh @@ -92,7 +92,7 @@ class WriteQueueEntry : public QueueEntry, public Printable /** WriteQueueEntry list iterator. */ typedef List::iterator Iterator; - bool sendPacket(BaseCache &cache); + bool sendPacket(BaseCache &cache) override; private: @@ -171,7 +171,7 @@ class WriteQueueEntry : public QueueEntry, public Printable */ void print(std::ostream &os, int verbosity = 0, - const std::string &prefix = "") const; + const std::string &prefix = "") const override; /** * A no-args wrapper of print(std::ostream...) meant to be * invoked from DPRINTFs avoiding string overheads in fast mode -- 2.30.2