From 582c86346d77538009d993c4cf8c7aa4021c0ad0 Mon Sep 17 00:00:00 2001 From: Ilia Mirkin Date: Tue, 6 Aug 2019 22:54:56 -0400 Subject: [PATCH] st/mesa: relax EXT_shader_image_load_store enable MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit There's no reason to bring format-less load requirement into this extension. It requires a size to be provided, and a compatible format is computed from the size + data type. For example layout(size1x32) uniform iimage1D image; becomes DCL IMAGE[0], 1D, PIPE_FORMAT_R32_SINT, WR whereas PIPE_CAP_IMAGE_LOAD_FORMATTED is designed to allow PIPE_FORMAT_NONE to be provided as a format and still enable LOAD operations to be performed. So the shader has all the information it needs about the format. Signed-off-by: Ilia Mirkin Reviewed-by: Marek Olšák --- src/mesa/state_tracker/st_extensions.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index b31869e059e..50471d63f2b 100644 --- a/src/mesa/state_tracker/st_extensions.c +++ b/src/mesa/state_tracker/st_extensions.c @@ -1182,9 +1182,6 @@ void st_init_extensions(struct pipe_screen *screen, extensions->OES_sample_variables = extensions->ARB_sample_shading && extensions->ARB_gpu_shader5; - extensions->EXT_shader_image_load_store &= - screen->get_param(screen, PIPE_CAP_IMAGE_LOAD_FORMATTED); - /* Maximum sample count. */ { static const enum pipe_format color_formats[] = { -- 2.30.2