From 5876a4c71d382070541b11f3771d9af7b50c5d4f Mon Sep 17 00:00:00 2001 From: Richard Sandiford Date: Tue, 4 Jun 2013 21:19:41 +0100 Subject: [PATCH] draw: Fix type mismatch between draw_private.h and LLVM draw_vertex_buffer declared the size field to be a size_t, but the LLVM code used an int32 instead. This caused problems on big-endian 64-bit targets, because the first 32-bit chunk of the 64-bit size_t was always 0. In one sense size_t seems like a good choice for a size, so one fix would have been to try to get the LLVM code to use the equivalent of size_t too. However, in practice, the size is taken from things like ~0 or width0, both of which are int-sized, so it seemed simpler to make the size field int-sized as well. Reviewed-by: Adam Jackson Signed-off-by: Richard Sandiford --- src/gallium/auxiliary/draw/draw_private.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/draw/draw_private.h b/src/gallium/auxiliary/draw/draw_private.h index f30f9af388b..adde647c4c4 100644 --- a/src/gallium/auxiliary/draw/draw_private.h +++ b/src/gallium/auxiliary/draw/draw_private.h @@ -71,7 +71,7 @@ struct draw_pt_front_end; */ struct draw_vertex_buffer { const void *map; - size_t size; + uint32_t size; }; /** -- 2.30.2